After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604872 - [udpsink] Add missing 'gssize len' parameter to g_convert()
[udpsink] Add missing 'gssize len' parameter to g_convert()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-12-18 01:09 UTC by Andoni Morales
Modified: 2010-02-09 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed path (860 bytes, patch)
2009-12-18 01:11 UTC, Andoni Morales 		none Details | Review
Proposed patch (857 bytes, patch)
2009-12-18 01:18 UTC, Andoni Morales 		none Details | Review
Proposed patch using sizeof instead of strlen (857 bytes, patch)
2009-12-18 01:22 UTC, Andoni Morales 		none Details | Review
Proposed patch using sizeof instead of strlen (857 bytes, patch)
2009-12-18 01:25 UTC, Andoni Morales 		none Details | Review

Description Andoni Morales 2009-12-18 01:09:09 UTC 
g_convert is missing the lenght parameter
Attached proposed patch
Comment 1 Andoni Morales 2009-12-18 01:11:51 UTC 
Created attachment 149953 [details] [review]
Proposed path
Comment 2 Andoni Morales 2009-12-18 01:18:12 UTC 
Created attachment 149954 [details] [review]
Proposed patch
Comment 3 Andoni Morales 2009-12-18 01:22:50 UTC 
Created attachment 149955 [details] [review]
Proposed patch using sizeof instead of strlen

This is probably a better fix
Comment 4 Andoni Morales 2009-12-18 01:25:55 UTC 
Created attachment 149956 [details] [review]
Proposed patch using sizeof instead of strlen

I sent twice the same patch...
Comment 5 Andoni Morales 2009-12-21 01:14:57 UTC 
Or maybe  sizeof (buf) / sizeof (wchar_t)?
Comment 6 Michael Smith 2009-12-21 01:26:35 UTC 
Neither of those are exactly right; in this case we want to pass -1 to indicate 'input buffer is null terminated'. Pushed; this should work now. Thanks for pointing that out.