After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604494 - seahorse FTBFS on some systems because of MAXPATHLEN usage
seahorse FTBFS on some systems because of MAXPATHLEN usage
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
2.28.x
Other GNU Hurd
: Normal normal
: 2.26.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2009-12-13 23:23 UTC by Emilio Pozuelo Monfort
Modified: 2009-12-14 15:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use dynamic allocation rather than fixed MAXPATHLEN size buffers (1.34 KB, patch)
2009-12-13 23:24 UTC, Emilio Pozuelo Monfort 		accepted-commit_now Details | Review

Description Emilio Pozuelo Monfort 2009-12-13 23:23:27 UTC 
MAXPATHLEN is undefined on some systems, but seahorse uses it unconditionally. That causes a build failure on GNU/Hurd.

This patch changes that to use dynamic allocation
Comment 1 Emilio Pozuelo Monfort 2009-12-13 23:24:04 UTC 
Created attachment 149661 [details] [review]
Use dynamic allocation rather than fixed MAXPATHLEN size buffers
Comment 2 Adam Schreiber 2009-12-14 02:01:29 UTC 
Review of attachment 149661 [details] [review]:

Looks good.  Let me know if you don't have commit access.
Comment 3 Emilio Pozuelo Monfort 2009-12-14 15:22:24 UTC 
Thanks, committed to master:

http://git.gnome.org/cgit/seahorse/commit/?id=b497a91cfeea3d24eab10e39ba6485754c92717f