After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604448 - gtk-vnc FTBFS on some platforms because of PATH_MAX usage
gtk-vnc FTBFS on some platforms because of PATH_MAX usage
Status: RESOLVED FIXED
Product: gtk-vnc
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-vnc-maint
gtk-vnc-maint
Depends on:
Blocks:
 
 
Reported: 2009-12-13 15:00 UTC by Emilio Pozuelo Monfort
Modified: 2010-03-20 18:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use dynamic allocation rather than fixed PATH_MAX size buffers (3.25 KB, patch)
2009-12-13 15:02 UTC, Emilio Pozuelo Monfort 		none Details | Review

Description Emilio Pozuelo Monfort 2009-12-13 15:00:41 UTC 
Hi,

gtk-vnc unconditionally uses PATH_MAX, but it may not be defined on some systems, like in GNU/Hurd. I'm attaching a patch that changes it to use dynamic allocation instead of a fixed buffer size.
Comment 1 Emilio Pozuelo Monfort 2009-12-13 15:02:02 UTC 
Created attachment 149637 [details] [review]
Use dynamic allocation rather than fixed PATH_MAX size buffers
Comment 2 Guido Günther 2010-03-05 18:17:53 UTC 
Can this be applied? We're shipping this in Debian as a sperate patch.
Comment 3 Daniel P. Berrange 2010-03-20 18:45:26 UTC 
Thanks I have applied your patch in this commit

commit 0a6bae9c19e9f86dda5433d8260d5f29e7ef4ed1
Author: Emilio Pozuelo Monfort <pochu27@gmail.com>
Date:   Sat Mar 20 18:44:26 2010 +0000

    Remove use of PATH_MAX in favour of dynamic buffers
    
    GNU/Hurd does not define the PATH_MAX constant. Replace use of
    PATH_MAX with dynamic buffers instead.
    
    * src/vncdisplay.c: Remove use of PATH_MAX