GNOME Bugzilla – Bug 604200
Compile issue: Use of deprecated clutter functions
Last modified: 2009-12-14 17:02:14 UTC
Using the git master of Mutter and Clutter, the build process stops because of the use of deprecated Clutter functions: --- cc1: warnings being treated as errors compositor/mutter-texture-tower.c: In function 'mutter_texture_tower_set_base_texture': compositor/mutter-texture-tower.c:171: error: 'cogl_offscreen_unref' is deprecated (declared at /usr/include/clutter-1.0/cogl/cogl-offscreen.h:98) compositor/mutter-texture-tower.c: In function 'texture_tower_revalidate_fbo': compositor/mutter-texture-tower.c:462: error: 'cogl_push_draw_buffer' is deprecated (declared at /usr/include/clutter-1.0/cogl/cogl.h:833) compositor/mutter-texture-tower.c:463: error: 'cogl_set_draw_buffer' is deprecated (declared at /usr/include/clutter-1.0/cogl/cogl.h:823) compositor/mutter-texture-tower.c:478: error: 'cogl_pop_draw_buffer' is deprecated (declared at /usr/include/clutter-1.0/cogl/cogl.h:842) make[4]: *** [mutter-texture-tower.o] Error 1 --- This is what the Clutter people say: --- cogl_push_draw_buffer, cogl_set_draw_buffer and cogl_pop_draw_buffer are now deprecated and new code should use the new cogl_framebuffer_* API instead. Code that previously did: cogl_push_draw_buffer (); cogl_set_draw_buffer (COGL_OFFSCREEN_BUFFER, buffer); /* draw */ cogl_pop_draw_buffer (); should now be re-written as: cogl_push_framebuffer (buffer); /* draw */ cogl_pop_framebuffer (); --- http://git.clutter-project.org/cgit.cgi?url=clutter/commit/&id=439f8 So I guess the fix should be straight forward.
Created attachment 149607 [details] [review] migrate to new cogl framebuffer framework this fixes the compile error, and should work as expected
Patch applied, thanks! I fixed up the commit message just a bit: - Capitalize first letter - Add a descriptive body to the commit message