After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604196 - Remove GdkFont deprecated code
Remove GdkFont deprecated code
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
2.90.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 597742
 
 
Reported: 2009-12-09 16:55 UTC by Christian Dywan
Modified: 2010-06-28 21:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove GdkFont (130.16 KB, patch)
2009-12-09 16:55 UTC, Christian Dywan 		none Details | Review
Remove GdkFont #2 (140.25 KB, patch)
2009-12-09 19:31 UTC, Christian Dywan 		none Details | Review
Remove GdkFont #3 (166.70 KB, patch)
2010-05-12 05:02 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
[GtkFontSel] Remove GdkFont "font" deprecated property (4.13 KB, patch)
2010-06-24 23:07 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
[GdkGC] Remove deprecated GdkFont from GdkGCValues structure (8.56 KB, patch)
2010-06-24 23:08 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Remove deprecated code from X interaction (18.10 KB, patch)
2010-06-24 23:09 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
[GtkStyle] Remove deprecated GdkFont (2.25 KB, patch)
2010-06-24 23:09 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Remove deprecated GdkFont (85.00 KB, patch)
2010-06-24 23:11 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Remove GDK_GC_FONT (4.09 KB, patch)
2010-06-25 00:29 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Remove XID_FONT_BIT (1.29 KB, patch)
2010-06-25 00:29 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Christian Dywan 2009-12-09 16:55:08 UTC 
I removed GdkFont and uses of GdkFont, such as gtk_draw_text and other uses. I would like someone to have a look over it, and see if this is correct since it touches a lot of obscure places.
Comment 1 Christian Dywan 2009-12-09 16:55:39 UTC 
Created attachment 149459 [details] [review]
Remove GdkFont
Comment 2 Christian Dywan 2009-12-09 19:31:59 UTC 
Created attachment 149473 [details] [review]
Remove GdkFont #2

Updated patch, as Javier pointed out I had missed a few occurances. This time I carefully searched the whole tree for "GdkFont".
Comment 3 Javier Jardón (IRC: jjardon) 2010-05-12 05:02:12 UTC 
Created attachment 160885 [details] [review]
Remove GdkFont #3

Updated Christian patch against current master.

I've also removed the deprecated documentation, some code from the others backends and some symbols from gdk.symbols, so make check is working now.
Comment 4 Javier Jardón (IRC: jjardon) 2010-06-24 23:07:01 UTC 
I've divided the patch in smaller patches. Hope this makes more easy the review:
Comment 5 Javier Jardón (IRC: jjardon) 2010-06-24 23:07:53 UTC 
Created attachment 164560 [details] [review]
[GtkFontSel] Remove GdkFont "font" deprecated property
Comment 6 Javier Jardón (IRC: jjardon) 2010-06-24 23:08:30 UTC 
Created attachment 164561 [details] [review]
[GdkGC] Remove deprecated GdkFont from GdkGCValues structure
Comment 7 Javier Jardón (IRC: jjardon) 2010-06-24 23:09:05 UTC 
Created attachment 164562 [details] [review]
Remove deprecated code from X interaction
Comment 8 Javier Jardón (IRC: jjardon) 2010-06-24 23:09:32 UTC 
Created attachment 164563 [details] [review]
[GtkStyle] Remove deprecated GdkFont
Comment 9 Javier Jardón (IRC: jjardon) 2010-06-24 23:11:04 UTC 
Created attachment 164564 [details] [review]
 Remove deprecated GdkFont
Comment 10 Matthias Clasen 2010-06-24 23:22:50 UTC 
Look reasonable, for what they do. A few things are left to clean up after this series, I think:

- the XID_FONT_BIT hack in gdkxid.c

- GDK_GC_FONT in GdkGCValuesMask
Comment 11 Javier Jardón (IRC: jjardon) 2010-06-25 00:29:00 UTC 
Created attachment 164571 [details] [review]
Remove GDK_GC_FONT
Comment 12 Javier Jardón (IRC: jjardon) 2010-06-25 00:29:35 UTC 
Created attachment 164572 [details] [review]
Remove XID_FONT_BIT
Comment 13 Javier Jardón (IRC: jjardon) 2010-06-28 21:45:22 UTC 
Comment on attachment 164560 [details] [review]
[GtkFontSel] Remove GdkFont "font" deprecated property

commit 418d84f3114548381ca86745d54fad2d7be8cc98
Comment 14 Javier Jardón (IRC: jjardon) 2010-06-28 21:45:54 UTC 
Comment on attachment 164561 [details] [review]
[GdkGC] Remove deprecated GdkFont from GdkGCValues structure

commit c3987f9ee2cf0ee2277c31e711755257f62c46db
Comment 15 Javier Jardón (IRC: jjardon) 2010-06-28 21:46:25 UTC 
Comment on attachment 164562 [details] [review]
Remove deprecated code from X interaction

commit c1affa4f3cbe51574a1895df9c4d9b77f50f81aa
Comment 16 Javier Jardón (IRC: jjardon) 2010-06-28 21:46:48 UTC 
Comment on attachment 164563 [details] [review]
[GtkStyle] Remove deprecated GdkFont

commit 34573b53f3926c2081bcce585f5e99680fb874a6
Comment 17 Javier Jardón (IRC: jjardon) 2010-06-28 21:47:29 UTC 
Comment on attachment 164564 [details] [review]
 Remove deprecated GdkFont

commit 655dcff09622777765f32d84549a7779c78147a5
Comment 18 Javier Jardón (IRC: jjardon) 2010-06-28 21:47:56 UTC 
Comment on attachment 164571 [details] [review]
Remove GDK_GC_FONT

commit 06e48c50a1080696bc0bbbe5a15e3f3747617286
Comment 19 Javier Jardón (IRC: jjardon) 2010-06-28 21:48:21 UTC 
Comment on attachment 164572 [details] [review]
Remove XID_FONT_BIT

commit b4ed51fd93760af43f09735b4f26506d9b172709
Comment 20 Javier Jardón (IRC: jjardon) 2010-06-28 21:49:35 UTC 
GdkFont is completely removed now. Closing.