After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603923 - [annotations] gtk_tree_store_newv/set_column_types
[annotations] gtk_tree_store_newv/set_column_types
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: Small fix
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-12-06 20:03 UTC by Viktor Pracht
Modified: 2010-02-19 20:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixed parameter types for GtkTreeStore (596 bytes, patch)
2009-12-06 20:03 UTC, Viktor Pracht 		none Details | Review
Fixed parameter types for GtkTreeStore (596 bytes, patch)
2009-12-07 17:43 UTC, Viktor Pracht 		needs-work Details | Review
Fixed parameter types for GtkTreeStore (703 bytes, patch)
2009-12-10 07:10 UTC, Viktor Pracht 		none Details | Review

Description Viktor Pracht 2009-12-06 20:03:56 UTC 
Created attachment 149209 [details] [review]
Fixed parameter types for GtkTreeStore

Gtk-custom.c is missing some custom magic for GtkTreeStore that's already present for GtkListStore. See the patch.
Comment 1 Johan (not receiving bugmail) Dahlin 2009-12-07 14:36:49 UTC 
The patch adds another set of annotation for GtkListStore, don't think that's what you had in mind.
Comment 2 Viktor Pracht 2009-12-07 17:43:39 UTC 
Created attachment 149280 [details] [review]
Fixed parameter types for GtkTreeStore

Oops, forgot to rename the functions after copy&paste.
Comment 3 Johan (not receiving bugmail) Dahlin 2009-12-07 18:10:32 UTC 
Review of attachment 149280 [details] [review]:

::: gir/Gtk-custom.c
@@ +1448,3 @@
+ * @columns: (array length=n_values): List of columns
+ * @iter:
+ * gtk_tree_store_set_valuesv:

this is wrong
Comment 4 Viktor Pracht 2009-12-08 07:46:24 UTC 
Err... maybe because you have the 3 lines backwards? I'm confused.
Comment 5 Johan (not receiving bugmail) Dahlin 2009-12-09 11:26:57 UTC 
Oops, that's because the code review messed things up.
You still mention #GtkListStore in the doc string.
Comment 6 Viktor Pracht 2009-12-10 07:10:39 UTC 
Created attachment 149502 [details] [review]
Fixed parameter types for GtkTreeStore

Fixed the doc string and added gtk_tree_store_newv, which was missing.
Comment 7 Johan (not receiving bugmail) Dahlin 2010-02-19 13:43:44 UTC 
Moving to gtk+, we shouldn't really modify gir-repository any more.
Comment 8 Johan (not receiving bugmail) Dahlin 2010-02-19 20:58:25 UTC 
Fixed in gtk+ HEAD