GNOME Bugzilla – Bug 603817
Show less stuff on panel on low resolutions
Last modified: 2010-08-11 14:05:32 UTC
Created attachment 149121 [details] [review] Patch to save some panel space We have this patch in openSUSE, and I'm wondering what you think about it -- whether it makes sense for it upstream. It hides the clock if the screen width is less than 1024, and it can also hide the labels for the option widgets if the width is less than 1280. Any opinion on this?
Review of attachment 149121 [details] [review]: I'm okay with it generally (not sure about yippi and mccann's opinion). I think a nicer solution, though, might be to degenerate dynamically based on crowding. e.g., don't say if "screen < blah run in low res mode" instead say "if panel doesn't have enough room for clock, hide clock". ::: gdm-2.29.1.orig/gui/simple-greeter/gdm-greeter-panel.c @@ +970,3 @@ + if (!screen) + screen = gdk_screen_get_default (); + should ben screen == NULL and should have braces to match gdm style @@ +973,3 @@ + /* If resolution is limited, hide clock to conserve horizontal space */ + + if (!screen || gdk_screen_get_width (screen) >= 1024) checking the screen width isn't right. if you have a netbook plugged into an external monitor and the login screen ends up on the netbook, you still want to hide things. ::: gdm-2.29.1.orig/gui/simple-greeter/gdm-option-widget.c @@ +656,3 @@ + if (!screen || gdk_screen_get_width (screen) >= 1280) + gtk_widget_show (widget->priv->label); + same deal, needs spacing fixes and == NULL, and checking screen width is wrong. should check monitor width instead (or better yet be less hard coded and more dynamic)
I don't mind if GDM has smarts to make it look better. However, I think that users, or at least the sysadmin should have control over what features are available. Removing an arbitrary applet based on an arbitrary pixel size seems wrong. The sysadmin should have the ability to configure which applets are shown in the panel in general. If we have features to hide applets based on "crowding", then the sysadmin should be able to enable or disable this feature. Also, I think that it would be nice if the sysadmin could decide what applets are removed when crowding happens. Perhaps gconf keys could be used to store this sort of configuration. This is a bit more complicated than the proposed patch, but I think it would be better if this were more configurable. If others feel that the proposed patch is good enough for now, then we can discuss. I'm not strongly opposed to this particular hack if people think it's a reasonable feature until more sophisticated configuration is available.
Comment on attachment 149121 [details] [review] Patch to save some panel space Prefer to go with something that hides things as needed rather than use magic values.
isn't that issue fixed in the current version with the labels not being displayed next to the entries?
Yeah, I guess it is.