GNOME Bugzilla – Bug 603801
Use gupnp rather than a code copy of miniupnp
Last modified: 2020-11-12 12:24:48 UTC
Hi, Vino currently ships a code copy of miniupnp which uses for UPnP support. I don't like code copies, so I think Vino should use libgupnp, which by the way is more GLibish :)
Not to mention that there is GUPnP-IGD helper which probably does what vino wants to do in one method call (I'm assuming UPnP is just used to open the port). http://folks.o-hand.com/ross/gupnp-docs/gupnp-igd/
Debian & Ubuntu now have miniupnpc in their repositories. If miniupnp has to be used, it would be nice (for security updates among other reasons) to at least have an option of using the system-installed version rather than a bundled library. http://packages.qa.debian.org/miniupnpc
Hi, could we have some input from upstream if building against a miniupnpc system lib would be acceptable? We do have the following patch in the Debian patch tracker http://patch-tracker.debian.org/patch/series/view/vino/3.2.2-1/05_use-system-miniupnpc.patch
Using gupnp or gupnp-igd directly would be nicer than changing which library we link against (especially when it's not part of our stack). (In reply to comment #1) > Not to mention that there is GUPnP-IGD helper which probably does what vino > wants to do in one method call (I'm assuming UPnP is just used to open the > port). > > http://folks.o-hand.com/ross/gupnp-docs/gupnp-igd/ I think it also uses it to query which is the outside-visible hostname to connect to.
Vino is not under active development anymore and unmaintained. Please use gnome-remote-desktop instead. Closing this report as WONTFIX to reflect reality.