After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603727 - Remove deprecated Glib symbols
Remove deprecated Glib symbols
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
2.23.x
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks: 560423
 
 
Reported: 2009-12-03 20:12 UTC by Javier Jardón (IRC: jjardon)
Modified: 2015-02-07 16:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
g_mapped_file_free (1.42 KB, patch)
2009-12-03 20:12 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Correct patch (1.42 KB, patch)
2009-12-03 20:13 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
g_mapped_file_free (3.23 KB, patch)
2009-12-03 20:16 UTC, Javier Jardón (IRC: jjardon) 		needs-work Details | Review
g_mapped_file_free.v2 (2.50 KB, patch)
2009-12-03 20:46 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
g_mapped_file_free.v3 (3.71 KB, patch)
2009-12-04 13:14 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Substitute deprecated Glib symbol: g_mapped_file_free (3.76 KB, patch)
2009-12-15 13:08 UTC, Johan (not receiving bugmail) Dahlin 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-12-03 20:12:02 UTC 
Created attachment 149031 [details] [review]
g_mapped_file_free

See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/Glib for more info
Comment 1 Javier Jardón (IRC: jjardon) 2009-12-03 20:13:27 UTC 
Created attachment 149032 [details] [review]
Correct patch
Comment 2 Javier Jardón (IRC: jjardon) 2009-12-03 20:16:03 UTC 
Created attachment 149033 [details] [review]
g_mapped_file_free

Damn, I'm sorry. This is the correct patch
Comment 3 Johan (not receiving bugmail) Dahlin 2009-12-03 20:17:56 UTC 
Review of attachment 149033 [details] [review]:

::: girepository/Makefile.am
@@ +10,3 @@
 libgirepository_1_0_la_SOURCES =		\
 
+	glib-compat.h				\

Keep this sorted alphabetically

::: girepository/glib-compat.h
@@ +20,3 @@
+ * This library is free software; you can redistribute it and/or
+ * Copyright (C) 2009 Javier Jardón
+/* GObject introspection: Compatibility definitions

We do want to use this for 2.24 etc, instead of just only on 2.22.
Comment 4 Javier Jardón (IRC: jjardon) 2009-12-03 20:46:09 UTC 
Created attachment 149035 [details] [review]
g_mapped_file_free.v2

I've reordered the files.

Also, I think you can use the header for glib versions >= 2.22: GLIB_CHECK_VERSION returns TRUE if the version of the GLib header files is the same as or newer than the passed-in version.
Comment 5 Johan (not receiving bugmail) Dahlin 2009-12-04 11:23:45 UTC 
Comment on attachment 149035 [details] [review]
g_mapped_file_free.v2

This patch is missing glib-compat.h again.
Comment 6 Javier Jardón (IRC: jjardon) 2009-12-04 13:14:17 UTC 
Created attachment 149083 [details] [review]
g_mapped_file_free.v3
Comment 7 Johan (not receiving bugmail) Dahlin 2009-12-15 13:08:05 UTC 
The following fix has been pushed:
a6a9954 Substitute deprecated Glib symbol: g_mapped_file_free
Comment 8 Johan (not receiving bugmail) Dahlin 2009-12-15 13:08:10 UTC 
Created attachment 149762 [details] [review]
Substitute deprecated Glib symbol: g_mapped_file_free

glib-compat.h file created to use g_mapped_file_unref only if
glib >= 2.22 is available
Comment 9 André Klapper 2015-02-07 16:53:32 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]