After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603651 - Remove redundant parameters in location-entry/action/toolbar API
Remove redundant parameters in location-entry/action/toolbar API
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-12-02 22:00 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2009-12-04 18:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove redundant parameters in location-set API (12.80 KB, patch)
2009-12-02 22:17 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2009-12-02 22:00:41 UTC 
Patch follows.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2009-12-02 22:17:29 UTC 
Created attachment 148957 [details] [review]
Remove redundant parameters in location-set API

EphyLocationEntry, EphyLocationAction and EphyToolbar were carrying around an
extra typed_address parameter that is not really used.
In the process, make ephy_location_entry_set_location accept NULL as @address
safely.

Bug #603651
Comment 2 Xan Lopez 2009-12-04 11:15:35 UTC 
You can also remove the typed_address member in the EphyLocationAction private data, since it's not used anymore. Also, I'd clarify in the comment that the parameters *are* used, but that the decision can be made in EphyWindow about which one we need instead of passing them along all widgets.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2009-12-04 18:10:43 UTC 
Comment on attachment 148957 [details] [review]
Remove redundant parameters in location-set API

5aee0deca12e14554ce0fa0d4b02613e99ba77a9
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2009-12-04 18:11:54 UTC 
Done with your comments.