GNOME Bugzilla – Bug 603472
Rename "Hidden" to "Invisible"
Last modified: 2011-08-29 10:12:28 UTC
Empathy uses the Label "Hidden" in the drop down menu for the user-status "Invisible". I'm referring to this as invisible since "Invisible" is the name used in the statuses by google , yahoo , aol accounts and the same "Invisible" is used in their respective IM clients. [hotmail/msn uses "appear offline" for this] It would be nice if empathy matches the actual label used by the chat services for this status and renames "Hidden" to "Invisible" . PS: http://www.szetopia.com/im-presence , lists the IM statuses used.
Right, even XMPP seems to use "invisible". I guess we used "hidden" as that's the name in the Telepathy spec.
Should be easy to fix.
Created attachment 151547 [details] [review] Changed the Status String from Hidden to Invisible This patch contains the fix which would change the Status String from Hidden to Invisible
any chance of this getting into 2.29.6?
Review of attachment 151547 [details] [review]: Hi Balaji. Thanks a lot for your patch. I added some comments. Any chance you could fix them and provide a new patch? ::: libempathy/empathy-idle.c @@ +99,3 @@ "away", "xa", + "invisible", You shouldn't change this string. We are using the "status" defined in the Telepathy specification: http://telepathy.freedesktop.org/spec/org.freedesktop.Telepathy.Connection.Interface.SimplePresence.html ::: libempathy/empathy-utils.c @@ +60,3 @@ { "away", TP_CONNECTION_PRESENCE_TYPE_AWAY }, { "ext_away", TP_CONNECTION_PRESENCE_TYPE_EXTENDED_AWAY }, + { "invisible", TP_CONNECTION_PRESENCE_TYPE_HIDDEN }, So this one shouldn't change either.
Created attachment 151670 [details] [review] Updated Patch to display Invisible to the user rather than Hidden Hi This is the updated patch which displays Invisible to the user rather than displaying Hidden. Thanks, Cheers, - Balaji
Merged to master. Thanks a lot! This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.