After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603197 - [patch] RemoveDeprecatedSymbols/Glib
[patch] RemoveDeprecatedSymbols/Glib
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks: 560423
 
 
Reported: 2009-11-28 02:30 UTC by Michael Callahan
Modified: 2009-12-02 20:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix issue (871 bytes, patch)
2009-11-28 02:30 UTC, Michael Callahan 		none Details | Review
guarded patch to replace g_mapped_file_free with g_mapped_file_unref (929 bytes, patch)
2009-11-28 17:31 UTC, Michael Callahan 		none Details | Review

Description Michael Callahan 2009-11-28 02:30:29 UTC 
Created attachment 148631 [details] [review]
patch to fix issue

This patch replaces the deprecated g_mapped_file_free with g_mapped_file_unref
Comment 1 Javier Jardón (IRC: jjardon) 2009-11-28 02:50:01 UTC 
Hello Michael, thank you for the patch.

Did you check the glib required version for this function? Does gtksourceview depends on it?
If not, you can bump the gtksourceview glib required version or surround the code with:

#if GLIB_CHECK_VERSION(2,22,0)
#else
#endif
Comment 2 Michael Callahan 2009-11-28 03:21:04 UTC 
It currently requires 2.14.  Would it be better to bump the requirement or use the ifdef?
Comment 3 Paolo Borelli 2009-11-28 09:51:33 UTC 
let's use an ifdef for now, it is silly to bump deps so much just because of this function.
Comment 4 Michael Callahan 2009-11-28 17:31:34 UTC 
Created attachment 148660 [details] [review]
guarded patch to replace g_mapped_file_free with g_mapped_file_unref

Alright!  Here is the patch guarded with the appropriate glib version ifdef.
Comment 5 Ignacio Casal Quinteiro (nacho) 2009-12-02 20:25:24 UTC 
Patch applied, thanks a lot for it.