GNOME Bugzilla – Bug 602556
x264enc and ffenc upstream GstForceKeyUnit handling are not thread-safe
Last modified: 2009-11-22 06:08:34 UTC
The implementation of GstForceKeyUnit in both of these elements are not thread safe (since the element reading the modified variable is very likely in another thread). Also, I implemented pushed back a GstForceKeyUnit event downstream in both (like theoraenc already does). That will allow muxers and payloaders to react to it (the next step is to make the h264 payload resend the PPS/SPS in the downstream event).
Created attachment 148208 [details] [review] ffenc: Make keyframe forcing thread-safe Make the keyframe forcing thread-safe, also emit a downstream event to allow muxers or payloaders to react appropriately.
Created attachment 148209 [details] [review] x264enc: Make upstream GstForceKeyUnit thread-safe Also send the GstForceKeyUnit event downstream when an upstream on is received, allowing muxers or payloaders to take appropriate actions.
Looks good, please commit :)
Comment on attachment 148208 [details] [review] ffenc: Make keyframe forcing thread-safe commit b69fcc471ea268587a8796ddffc888f321933d0a Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Fri Nov 20 21:46:33 2009 -0500 ffenc: Make keyframe forcing thread-safe Make the keyframe forcing thread-safe, also emit a downstream event to allow muxers or payloaders to react appropriately. https://bugzilla.gnome.org/show_bug.cgi?id=602556
Comment on attachment 148209 [details] [review] x264enc: Make upstream GstForceKeyUnit thread-safe commit b7f37f9afbd98a6d3ee800e9f87c4d85fff0cc5b Author: Olivier Crête <olivier.crete@collabora.co.uk> Date: Fri Nov 20 21:32:31 2009 -0500 x264enc: Make upstream GstForceKeyUnit thread-safe Also send the GstForceKeyUnit event downstream when an upstream on is received, allowing muxers or payloaders to take appropriate actions. https://bugzilla.gnome.org/show_bug.cgi?id=602556
Patches merged