GNOME Bugzilla – Bug 602498
Crashes when setting cookies for about:blank
Last modified: 2009-11-23 08:38:33 UTC
In fact, setting cookies for anything that ends up with a NULL uri->host. I am coming from investigating this bug report in WebKit: https://bugs.webkit.org/show_bug.cgi?id=31658 Patch incoming.
Created attachment 148171 [details] [review] ignore cookies with no domain
Created attachment 148193 [details] [review] Don't crash when setting cookie for about:blank How about this instead? (It avoids even parsing the cookie if we're not going to keep it.) This adds some new g_return_if_fails(), but they shouldn't be triggered by anything WebKit is doing; if they are, that's a bug in my patch.
(In reply to comment #2) > Created an attachment (id=148193) [details] [review] > Don't crash when setting cookie for about:blank > > How about this instead? (It avoids even parsing the cookie if we're not > going to keep it.) This adds some new g_return_if_fails(), but they > shouldn't be triggered by anything WebKit is doing; if they are, that's > a bug in my patch. I've checked the different feeds from the various bug reports we have in Liferea that boiled down to this issue, and all work fine (and without running into the g_return_val_if_fail()'s) now.
Attachment 148193 [details] pushed as d9d564b - Don't crash when setting cookie for about:blank
Much better, thanks! =)