After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602493 - Double context menu
Double context menu
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: main
git master
Other Linux
: Normal normal
: ---
Assigned To: gnote-maint
gnote-maint
Depends on:
Blocks:
 
 
Reported: 2009-11-20 12:11 UTC by Aurimas Černius
Modified: 2010-01-04 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch, fixing the bug. (4.16 KB, patch)
2009-11-20 12:11 UTC, Aurimas Černius 		reviewed Details | Review
Proposed fix (4.17 KB, patch)
2010-01-04 12:50 UTC, Debarshi Ray 		none Details | Review

Description Aurimas Černius 2009-11-20 12:11:42 UTC 
Created attachment 148168 [details] [review]
Patch, fixing the bug.

In search all notes window:

1. Select notebook
2. Select note
3. Click on selected notebook
4. Press context menu key
=> Two context menus open.

Patch attached.
Comment 1 Debarshi Ray 2010-01-04 11:08:21 UTC 
Corresponding Tomboy bug: https://bugzilla.gnome.org/606007
Comment 2 Debarshi Ray 2010-01-04 12:46:25 UTC 
Review of attachment 148168 [details] [review]:

Good catch.

The even easier fix is to make NoteRecentChanges::on_notebooks_key_pressed return true instead of false so that other event handlers for the "key-pressed" event are not invoked after it.

The cleaner way to do it, in my opinion would be to have three different handlers. One for the window to deal with the escape, and one each for the two trees.
Comment 3 Debarshi Ray 2010-01-04 12:50:01 UTC 
Created attachment 150775 [details] [review]
Proposed fix
Comment 4 Debarshi Ray 2010-01-04 13:24:12 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.