After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602161 - bad .17 VPATH build fix
bad .17 VPATH build fix
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.x
Other All
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-17 05:40 UTC by Yaakov Selkowitz
Modified: 2009-11-18 07:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
bad .17 VPATH patch (945 bytes, patch)
2009-11-17 05:40 UTC, Yaakov Selkowitz 		committed Details | Review

Description Yaakov Selkowitz 2009-11-17 05:40:00 UTC 
Created attachment 147952 [details] [review]
bad .17 VPATH patch

Between -bad .16 and .17, there was an API change in gst_signal_processor_class_add_pad_template().  If .16 is already installed on the system and .17 is built VPATH ($top_builddir != $top_srcdir), then the .16 header is found and the compile of the ladspa and lv2 plugins fail with a "too few arguments" error.

Patch for .17 attached.
Comment 1 Sebastian Dröge (slomo) 2009-11-17 15:32:33 UTC 
Thanks, I'll push this after gst-plugins-bad is open again.

commit e535a3cdd3a4094aa2ba4dc337ba7d39f0cbfcd9
Author: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Date:   Tue Nov 17 16:31:09 2009 +0100

    signalprocessor: Use correct CFLAGS for the signalprocessor headers in LV2/L
    
    This makes sure that the headers from the source tree are taken and not
    accidentially installed system headers in the case of builddir!=srcdir.
    
    Fixes bug #602161.