After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602074 - Type names in variable lists are unreasonably truncated
Type names in variable lists are unreasonably truncated
Status: RESOLVED FIXED
Product: nemiver
Classification: Other
Component: general
trunk
Other Linux
: Normal minor
: ---
Assigned To: Nemiver maintainers
Nemiver maintainers
: 600224 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-11-16 09:29 UTC by Tom Hughes
Modified: 2009-11-23 10:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to stop nemiver truncating typenames (1000 bytes, patch)
2009-11-16 09:29 UTC, Tom Hughes
none Details | Review
Another proposed patch (19.20 KB, patch)
2009-11-22 17:13 UTC, Dodji Seketeli
none Details | Review

Description Tom Hughes 2009-11-16 09:29:09 UTC
Created attachment 147857 [details] [review]
Patch to stop nemiver truncating typenames

Nemiver truncates all type names displayed in variables lists at 15 characters (or the first newline) which seems rather short to me.

In particular it typically winds up with the bizarre situation where the variable list has all the type names truncated with "..." and then loads of white space to the right edge of the window.

The attached patch removes the limit so that it only truncates multiline names - the user is then free to adjust column widths to choose how to truncate things if there isn't enough space to show everything.

There might be an issue with the "hover over" variable display window though as that auto-sizes? So maybe we would still want to do truncation there? I'd still like it to be a bit more than 15 though - maybe double that?
Comment 1 Dodji Seketeli 2009-11-22 09:17:32 UTC
*** Bug 600224 has been marked as a duplicate of this bug. ***
Comment 2 Dodji Seketeli 2009-11-22 17:13:53 UTC
Created attachment 148284 [details] [review]
Another proposed patch

Hello Tom,

Thanks for your patch.

I agree that we should probably not truncate the type string for the local variable widget, but we should truncate it for things like the popup variable inspector widget. I also agree that by default, truncating at 15 characters is a bit tight.

This patch I am proposing does that. Whenever it truncates the type string, it does so at 50 characters. It doesn't truncate the type string in the local variable widget either.

I'll wait a little bit and commit this patch, in case someone has some comments.

Thank you for your time.
Comment 3 Tom Hughes 2009-11-23 09:16:39 UTC
That sounds like a reasonable solution to me, and the patch seems to be fine here.
Comment 4 Dodji Seketeli 2009-11-23 10:19:55 UTC
The patch is pushed to master and should be available in Nemiver 0.7.3
Thanks!