Created attachment 147383 [details] [review]
[dash] Move BackLink to CSS

Review of attachment 147383 [details] [review]:

Looks good overall.

You need to update data/Makefile.am to reflect that back.svg was moved to theme/section-back.svg

::: data/theme/gnome-shell.css
@@ +108,3 @@
 }
 
+.section-header-back {

This should also have "border-right: 1px solid #262626;" similarly to how the .more-link has the border on the left.

There should be the padding between the image and that border, but just adding "padding: 0px 4px 0px 0px;" doesn't work correctly because it doesn't apply the padding to the background image, and just centers the background image. So you need to add a wrapper box with right padding and right border in dash.js and put the back link there. You can also add a comment explaining why it's necessary and that it can use the margins instead once we have them.

You should also add "spacing: 4px;" to .section-header-inner to have some spacing between the separator (back link's right border) and the section title.

Attachment 147383 [details] pushed as af35dea - [dash] Move BackLink to CSS