GNOME Bugzilla – Bug 601108
gst-camera requires glade
Last modified: 2010-03-09 13:39:02 UTC
Should be using GtkBuilder instead
this is a test app :/ if anyone know how to migrate, patches welcome, pointer to how-tos too.
Created attachment 151522 [details] [review] Port from libglade to GtkBuilder Here a patch to port the tests to GtkBuilder. I've not tested the patch but I think should work. For info about migration take a look here: http://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder and here: http://library.gnome.org/devel/gtk/unstable/gtk-migrating-GtkBuilder.html
commit be9ca4d5e1665bf30b2cf0a01d469a7bf676b2be Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat Jan 16 11:41:20 2010 +0100 examples: Fix build and signal connection for GtkBuilder stuff commit cf89e526e30b9e380388acbbb108519019ab3aae Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat Jan 16 11:26:15 2010 +0100 configure: Check for gmodule-export-2.0 for GtkBuilder commit 55c48789b7902d78cc85599445aec6dfb6b6b7c6 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat Jan 16 11:23:00 2010 +0100 icles: Link with GTK+ commit 92b7c0ad15e7a396dc12b51c0b6e4f15343f2040 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat Jan 16 11:16:05 2010 +0100 configure: Require GTK+ >= 2.12 for GtkBuilder GTK+ 2.12 is already older than 2 years so this shouldn't be a problem for anybody. Also it's only used in examples. commit 878ccf4a56535765653f879af7dba1d0fb1c832c Author: Javier Jardón <jjardon@gnome.org> Date: Sat Jan 16 06:57:26 2010 +0100 tests: Port from libglade to GtkBuilder Fixes bug #601108.
even if you (In reply to comment #3) > commit cf89e526e30b9e380388acbbb108519019ab3aae > Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> > Date: Sat Jan 16 11:26:15 2010 +0100 > > configure: Check for gmodule-export-2.0 for GtkBuilder > > commit 92b7c0ad15e7a396dc12b51c0b6e4f15343f2040 > Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> > Date: Sat Jan 16 11:16:05 2010 +0100 > > configure: Require GTK+ >= 2.12 for GtkBuilder > > GTK+ 2.12 is already older than 2 years so this shouldn't > be a problem for anybody. Also it's only used in examples. i didn't look into these two commit, but i'm able to build gst-plugins-bad on rhel/centos-5 with glib-2.20.5 and with gtk2-2.10.4 which is older then the above GTK+ 2.12! the only thing i recognize is this line during the configure: ------------------------ configure: using GStreamer Base Plug-ins in /usr/lib/gstreamer-0.10 configure: Using GStreamer Base Plugins in /usr/lib/gstreamer-0.10 checking for GTK... no checking for GMODULE_EXPORT... yes ------------------------ so imho it'd have to somehow fixed. anyway the only reason for all current version ie: gstreamer-0.10.28 gstreamer-plugins-base-0.10.28 gstreamer-plugins-good-0.10.21 gstreamer-plugins-bad-0.10.18 gstreamer-plugins-ugly-0.10.14 is gst-camera which is require GTK+ >= 2.12. for everything else gtk2-2.10.4 is enough. so imho it's really questionable to fix this bug or leave it as it's now . since currently it can be build without GTK+ >= 2.12.
Levente Farkas: I am not sure I understand what you are asking for / arguing. If you have a too-old Gtk+, the gst-camera example will not be built, but it is still possible to build the rest of gst-plugins-bad of course. The bug has already been fixed. It was the right thing to do. Why do you say 'it is questionable to fix this bug or leave it as it's now'?
i said that the commit's changelog said configure: Require GTK+ >= 2.12 for GtkBuilder which is not true. it's just check whether gtk+ > 2.12 and if yes then build gst-camera otherwise don't. imho it's good behaviors and not do not force anyone to use gtk+ > 2.12.
Ok, so the commit message is a bit misleading, since it is a soft requirement only, but we can't change the commit message now in retrospect. Gtk+ should be an optional dependency here, I think we agree on that. So were you just nitpicking about the commit message, or is there anything wrong with our build setup and there are problems when buildling against older Gtk+ versions?
no everything else is ok.