After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 60002 - No way to detect new message in closed thread
No way to detect new message in closed thread
Status: VERIFIED FIXED
Product: balsa
Classification: Other
Component: general
1.2.x
Other All
: Normal normal
: 1.4
Assigned To: Carlos Morgado
Pawel Salek
Depends on:
Blocks:
 
 
Reported: 2001-09-04 13:47 UTC by Toralf Lund
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed implementation (6.30 KB, patch)
2001-09-05 11:27 UTC, Toralf Lund
none Details | Review

Description Toralf Lund 2001-09-04 13:47:17 UTC
There should *really* be some kind of indication somewhere when a closed
thread contains unread messages. Currently it's virtually impossible to
find out what's new in large mailboxes ;-( "Next unread" doesn't open
threads, either...
Comment 1 Toralf Lund 2001-09-05 11:27:16 UTC
Created attachment 5059 [details] [review]
Proposed implementation
Comment 2 Toralf Lund 2001-09-05 11:39:45 UTC
OK, my employer is probably going to chuck me out realy soon now for
spending too much time on this kind of stuff, but in the mean time,
tried to write some code that will mark collapsed threads that have
unread messages by setting "unread mailbox" style on the associated rows.

TODO:
1. Introduce a separate config setting for _threads_ with unread
messages, or at least store the style separately.
2. Find out if we want to mark _all_ threads with unread messages,
rather than just the collapsed ones.
3. Ensure display is updated when config is changed.
balsa_index_refresh()in balsa_window_refresh() may do the trick, but I
didn't add the call as I thought there might be a good reason for not
doing so since it's not there already.


Comment 3 Pawel Salek 2001-09-18 19:25:02 UTC
I am evaluating now all the pending patches.
Is this patch overlapping with #57569?
Comment 4 Pawel Salek 2001-09-18 19:57:35 UTC
OK, I have figured out the overlap. The patch has been commited to
CVS. I guess it is OK to mark this report as FIXED, isn't it?
Comment 5 Toralf Lund 2001-09-19 07:26:57 UTC
Well, it depends... Have you reviewed my TODO above?

Note on 2.: I really like the way it works now (i.e. after my patch is
applied) as it makes it immediately obvious which "open" boxes I need
to click on to find my messages. Maybe some don't agree, and think
that the highlighting shouldn't change just because you expand the
thread...
Comment 6 Pawel Salek 2001-09-19 08:19:23 UTC
Right, I somehow have not noticed the TODO list...
Comment 7 Carlos Morgado 2002-09-21 00:56:19 UTC
1.4 is out, everyone seems happy