After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599446 - atk_object_set_name () assertion in gtk_tool_button_set_label
atk_object_set_name () assertion in gtk_tool_button_set_label
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.18.x
Other Linux
: Normal normal
: ---
Assigned To: Li Yuan
Li Yuan
: 600234 602198 608366 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-10-23 21:07 UTC by Alexander V. Butenko
Modified: 2010-03-02 07:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Only set the accesible label if it is non-empty (855 bytes, patch)
2009-10-24 12:17 UTC, Christian Dywan
committed Details | Review

Description Alexander V. Butenko 2009-10-23 21:07:58 UTC
as a result functions like gtk_tool_button_new (NULL, NULL) gives a critical warnings
CRITICAL **: atk_object_set_name: assertion `name != NULL' failed
Comment 1 Christian Dywan 2009-10-24 12:17:11 UTC
Created attachment 146167 [details] [review]
Only set the accesible label if it is non-empty

This fixes the regression.
Comment 2 Matthias Clasen 2009-10-26 04:59:47 UTC
Looks good, please commit.
Comment 3 Javier Jardón (IRC: jjardon) 2009-10-26 23:35:27 UTC
Comment on attachment 146167 [details] [review]
Only set the accesible label if it is non-empty

commit 57af1cdb8caad86719b6f56d5026c12c7de52464
Comment 4 Javier Jardón (IRC: jjardon) 2009-10-26 23:35:47 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 5 Jonathon Jongsma 2009-11-06 04:10:57 UTC
can we get this into the 2-18 branch as well?
Comment 6 Matthias Clasen 2009-11-06 04:31:02 UTC
sure, feel free to cherry-pick it.
Comment 7 Christian Dywan 2009-11-06 09:43:32 UTC
Pushed to gtk-2-18.
Comment 8 Christian Dywan 2009-11-20 01:04:58 UTC
*** Bug 602198 has been marked as a duplicate of this bug. ***
Comment 9 Brian J. Murrell 2010-01-28 17:48:58 UTC
*** Bug 600234 has been marked as a duplicate of this bug. ***
Comment 10 Javier Jardón (IRC: jjardon) 2010-02-08 17:08:22 UTC
*** Bug 608366 has been marked as a duplicate of this bug. ***
Comment 11 Lior Solomon 2010-02-09 03:01:08 UTC
I'm using gtk-2-18 and still reproducing this problem

dpkg -l libgtk[0-9]* | grep ^i
ii  libgtk2-perl                               1:1.221-4                                  Perl interface to the 2.x series of the Gimp Toolkit library
ii  libgtk2.0-0                                2.18.3-1ubuntu2.2                          The GTK+ graphical user interface library
ii  libgtk2.0-bin                              2.18.3-1ubuntu2.2                          The programs for the GTK+ graphical user interface library
ii  libgtk2.0-cil                              2.12.9-1                                   CLI binding for the GTK+ toolkit 2.12
ii  libgtk2.0-common                           2.18.3-1ubuntu2.2                          Common files for the GTK+ graphical user interface library