After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599159 - Stop to handle tube channels
Stop to handle tube channels
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.28.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on: 599743
Blocks:
 
 
Reported: 2009-10-21 10:26 UTC by Guillaume Desmottes
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/tube-dispatch-599159 (38.61 KB, patch)
2010-01-14 14:58 UTC, Guillaume Desmottes
none Details | Review

Description Guillaume Desmottes 2009-10-21 10:26:55 UTC
Empathy shouldn't handle/dispatch tube channels in 2.30. All applications should use the proper MC5 API for that.
Comment 1 Guillaume Desmottes 2009-10-27 10:10:27 UTC
We should port Vinagre to MC5 before removing old tube dispatching (bug #599743).
Comment 2 André Klapper 2009-10-28 17:16:40 UTC
Currently 17 Empathy tickets are set as GNOME 2.30 blockers, hence mass-removing.
Guillaume: Please use normal Target Milestones instead. If you really think that this specific issue here is a 2.30 blocker then please restore the GNOME target and set corresponding importance values.
Comment 3 Guillaume Desmottes 2010-01-14 14:58:47 UTC
Created attachment 151401 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/tube-dispatch-599159

 extensions/Makefile.am            |    1 -
 extensions/Tube_Handler.xml       |   57 -----
 extensions/misc.xml               |    1 -
 libempathy/Makefile.am            |    2 -
 libempathy/empathy-dispatcher.c   |    2 -
 libempathy/empathy-tube-handler.c |  288 -----------------------
 libempathy/empathy-tube-handler.h |   64 -----
 po/POTFILES.in                    |    1 -
 src/.gitignore                    |    3 -
 src/Makefile.am                   |    5 +-
 src/empathy-event-manager.c       |  123 ----------
 src/empathy-tube-dispatch.c       |  467 -------------------------------------
 src/empathy-tube-dispatch.h       |   75 ------
 src/empathy.c                     |    6 -
 14 files changed, 1 insertions(+), 1094 deletions(-)
Comment 4 Guillaume Desmottes 2010-01-18 16:55:33 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.