After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599027 - [PATCH] Call unlink_streams in client_finalize
[PATCH] Call unlink_streams in client_finalize
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-20 09:36 UTC by Luca Ognibene
Modified: 2010-03-05 17:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.11 KB, patch)
2009-11-10 11:13 UTC, Luca Ognibene 		none Details | Review

Description Luca Ognibene 2009-10-20 09:36:49 UTC 
Sometime i get this segfault when a client connected to gst-rtsp-server segfaults:
[20/10/2009 10:44:56.478956]: client 0x84dae90: received an error System error: Connection reset by peer
[20/10/2009 10:44:56.479083]: finalize client 0x84dae90

GLib-CRITICAL **: g_async_queue_push: assertion `queue' failed
aborting...

+ Trace 218446

  • #0 __kernel_vsyscall
  • #1 *__GI_raise
    at ../nptl/sysdeps/unix/sysv/linux/raise.c line 64
  • #2 *__GI_abort
    at abort.c line 88
  • #3 IA__g_logv
    at /build/buildd/glib2.0-2.20.1/glib/gmessages.c line 506
  • #4 IA__g_log
    at /build/buildd/glib2.0-2.20.1/glib/gmessages.c line 526
  • #5 IA__g_return_if_fail_warning
    at /build/buildd/glib2.0-2.20.1/glib/gmessages.c line 541
  • #6 IA__g_async_queue_push
    at /build/buildd/glib2.0-2.20.1/glib/gasyncqueue.c line 223
  • #7 gst_rtsp_watch_queue_data
    at gstrtspconnection.c line 3023
  • #8 gst_rtsp_watch_queue_message
    at gstrtspconnection.c line 3065
  • #9 do_send_data
    at rtsp-client.c line 310
  • #10 handle_new_buffer
    at rtsp-media.c line 908
  • #11 gst_app_sink_render_common
    at gstappsink.c line 759 

I think the problem is that client_finalize is not calling unlink_streams. I'm attaching a patch that works for me.
Comment 1 Luca Ognibene 2009-11-10 11:13:09 UTC 
Created attachment 147359 [details] [review]
patch

ooops, i forgot to add the patch..
Comment 2 Wim Taymans 2010-03-05 17:38:23 UTC 
commit e19c382bbb648068cd46bef1d39723f971aa8d53
Author: Luca Ognibene <luca.ognibene at gmail.com>
Date:   Fri Mar 5 18:37:17 2010 +0100

    client: call unlink_streams in client finalize
    
    Fixes #599027