After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 598895 - [GstRegistry] Use hash table for feature lookups
[GstRegistry] Use hash table for feature lookups
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-19 07:18 UTC by Edward Hervey
Modified: 2009-10-22 10:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstregistry: Use hash table when finding a feature. (1.39 KB, patch)
2009-10-19 07:19 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2009-10-19 07:18:49 UTC 
In gst_registry_find_feature, we use a feature filter on an unsorted list instead of using the available sorted hash table.
Comment 1 Edward Hervey 2009-10-19 07:19:12 UTC 
Created attachment 145764 [details] [review]
gstregistry: Use hash table when finding a feature.
Comment 2 Sebastian Dröge (slomo) 2009-10-22 08:42:14 UTC 
Review of attachment 145764 [details] [review]:

That patch is obviously correct... any reason why you didn't commit this yet?

Also, did you measure the performance improvement? :)
Comment 3 Edward Hervey 2009-10-22 10:36:51 UTC 
commit 4b13520b6188ed755a22bf52bd3a4f442e8442b9
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Mon Oct 19 09:06:16 2009 +0200

    gstregistry: Use hash table when finding a feature. Fixes #598895