Created attachment 145620 [details] [review]
Parallelise building of non-core modules

Looks good in general, three things I noticed though:
- The >> failure.log part after git submodule update and the stash applying only talks about "updating", not what exactly was done
- Instead of failure.log better create a randomized temporary file ala mkstmp()
- If core/base fail to build you don't want to try to build any of the depending modules but stop

Also an option to parallelize it or not would be nice and a way to save complete build logs per module somewhere. With the parallel build it's almost impossible to do something useful with the terminal output because it's all interleaved :)

Created attachment 151656 [details] [review]
Parallelise building of non-core modules

OK, how about this?

Comment on attachment 151656 [details] [review]
Parallelise building of non-core modules

Looks good, please commit after freeze :)

There's no need to wait until after the freeze to commit this, I think :)

It doesn't really affect the build or code, and I probably won't update common before the release anyway.

I did add 'Closes bug #598700' and changed the commit log message to 'Parallelise building of non-core modules' but unfortunately I did it on the commit in my branch rather than in the merged commit in master. :/

commit 795495519a223d350d6ac55c445b37b488af3268
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Thu Jan 28 07:27:49 2010 +0100

    git-update.sh: Fix issues