GNOME Bugzilla – Bug 597888
Should build with -DGSEAL_ENABLE
Last modified: 2010-09-22 15:34:15 UTC
Created attachment 145111 [details] [review] Patch for this bug To be ready for GNOME 3 gnome-control-center should be able to build with -DGSEAL_ENABLE See http://live.gnome.org/GnomeGoals/UseGseal for more details Also replace hack in capplets/common/theme-thumbnail.c. Remaining functions: GTK_WIDGET_REALIZED GTK_WIDGET_SET_FLAGS (, GTK_NO_WINDOW)
Hello Maxim, You can substitute GTK_WIDGET_SET_FLAGS (, GTK_NO_WINDOW) with gtk_widget_set_has_window()
Created attachment 145498 [details] [review] Updated patch Remaining functions: GTK_WIDGET_REALIZED
Comment on attachment 145498 [details] [review] Updated patch I guess you wanted to remove that second line. + gtk_widget_set_has_window (scroll_area, TRUE); GTK_WIDGET_SET_FLAGS (scroll_area, GTK_NO_WINDOW); Also, this looks a bit odd: + <property name="yalign">0.4699999988079071</property> Since the patch does a lot more than just replace field accesses 1:1 it should wait until we've branched for 2.30. And I'm wondering if, when we have one function that calls gtk_get_xxx a dozen times, using a temporary var to store xxx might be a tad less, hm, verbose, at least.
(In reply to comment #3) > Since the patch does a lot more than just replace field accesses 1:1 it should > wait until we've branched for 2.30. Ping, as control-center has branched.
(In reply to comment #3) > (From update of attachment 145498 [details] [review]) > I guess you wanted to remove that second line. > > + gtk_widget_set_has_window (scroll_area, TRUE); > GTK_WIDGET_SET_FLAGS (scroll_area, GTK_NO_WINDOW); I think that this should be: gtk_widget_set_has_window (scroll_area, FALSE);
Created attachment 159042 [details] [review] Use accessor functions instead direct access
Review of attachment 159042 [details] [review]: The patch seems correct except the issue noted below. Also, It would be nice if you store the variables instead call the same function several times. ::: capplets/display/scrollarea.c @@ +765,3 @@ gdk_window_set_user_data (area->priv->input_window, area); + gtk_widget_get_window (widget))); + gtk_widget_set_style (widget, gtk_style_attach (gtk_widget_get_style (widget), You should use gtk_widget_style_attach () here.
Created attachment 159070 [details] [review] Use accessor functions instead direct access
(In reply to comment #7) > Also, It would be nice if you store the variables instead call the same > function several times. I'm with Javier here.
Created attachment 159123 [details] [review] Use accessor functions instead direct access don't call the same function several times
Comment on attachment 159123 [details] [review] Use accessor functions instead direct access Thanks, Maxim!
So this now "only" needs fixing of libslab, or what is left?
(In reply to comment #12) > So this now "only" needs fixing of libslab, or what is left? yes
Closing this, then.
Patch in bug 615292 comment 14 is needed to fix this => reopening.
Closing as #bug 615292 comment 14 is applied now
Closing for real :)