After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597265 - totem-pl-parser is not reentrant/mt safe
totem-pl-parser is not reentrant/mt safe
Status: RESOLVED DUPLICATE of bug 572705
Product: totem-pl-parser
Classification: Core
Component: General
2.28.x
Other Linux
: Normal critical
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks:
 
 
Reported: 2009-10-04 09:10 UTC by Sebastian Dröge (slomo)
Modified: 2009-10-04 23:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastian Dröge (slomo) 2009-10-04 09:10:00 UTC 
Hi,
see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=547683 for a larger description with backtraces and a complete analysis.

Patch for this is at http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=20;filename=make-reentrant.diff;att=1;bug=547683


Short story:
------------------------
line 154 of xmllexer.c is

      c = lexbuf[lexbuf_pos];

Here are the values of the interesting variables:

(gdb) p lexbuf
$6 = 0xb3a7e008 <Address 0xb3a7e008 out of bounds>
(gdb) p lexbuf_pos
$7 = 1659

lexbuf is a private, global variable.  If Rhythmbox is trying to parse
multiple podcasts simultaneously, this would cause a race condition
for this variable.
Comment 1 Sebastian Dröge (slomo) 2009-10-04 09:12:38 UTC 
I should probably note here, that the patch is by Matt Kraai <kraai@ftbfs.org> and not by me. Also I didn't take a closer look yet at the patch :)
Comment 2 Bastien Nocera 2009-10-04 23:30:27 UTC 
Patch is also in bug 572705, so closing this one.

*** This bug has been marked as a duplicate of bug 572705 ***