GNOME Bugzilla – Bug 597243
delete key on a clip in the source list should remove it only if the timeline is not focused
Last modified: 2010-02-17 08:35:53 UTC
The fix for bug #595402 caused a regression. As soon as you hit delete to remove a clip from the timeline, it is also removed from the source list, even if you were working on the timeline (and thus, it was focused). This is dangerous behavior.
Confirmed. What makes it worse is that you can't unselect a clip in the clip list, so you have to save, and then reopen to be able to use the delete key to delete objects from the timeline. (newly opened projects have no clips in the clip list selected, but if you have just added a clip, it's selected, and there's no way to unselect it that I saw) And I felt so proud fixing that bug :(
Changing component, raising the severity as it can cause data/work loss and is generally dangerous.
*** Bug 602893 has been marked as a duplicate of this bug. ***
Karl, are you able to make a new patch that would fix this?
I can't reproduce the problem anymore with the git version, I think it was fixed when Stephen's "icon view" branch was merged. I'm not sure I should reopen bug #595402 because I personally consider it to be a dangerous feature, and because it can be done with right-click or using the toplevel menus...
as Karl Palsson said on Bug 595402 : "if delete in the timeline deletes a clip, there's no reason that delete on the source list shouldn't delete the clip." If the fix can be properly implemented then there is no reason to not fix it
> "if delete in the timeline deletes a clip, > there's no reason that delete on the source list shouldn't delete the clip." My reasoning is the following: - We already have a popup menu and the toplevel menus to do that. - The user has to be 160% sure what is focused (timeline vs source list), which is not something I consider visually obvious and safe. - Removing a clip from the timeline has only local consequences; deleting from the source list is an action with *global consequences*: it deletes every instance of the clip you had in the timeline. - Removing something from the timeline is an action you do *often* in an editing workflow (think "remove the audio part of a clip after unlinking" or "remove leftovers of a split operation", for example), thus warranting the keyboard shortcut. Deleting something from a project entirely is not something that is expected to be done often. And if you want to "clean up" the project fast, then it's bug #583254 instead. As an analogy, you don't see a shortcut key to remove contacts from your pidgin/empathy buddy list, you can only do it with the menus... that's because it's dangerous and not supposed to be used often.
"emoving a clip from the timeline has only local consequences; deleting from the source list is an action with *global consequences*: it deletes every instance of the clip you had in the timeline" i didn't know about that... does pitivi show a warning about that ? i think it should