After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 597050 - [PATCH] Don't hardcode path to polkit-gnome-authentication-agent-1
[PATCH] Don't hardcode path to polkit-gnome-authentication-agent-1
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.28.x
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-01 21:26 UTC by Marcin Banasiak
Modified: 2013-11-11 16:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix (2.23 KB, patch)
2009-10-01 21:26 UTC, Marcin Banasiak
committed Details | Review

Description Marcin Banasiak 2009-10-01 21:26:23 UTC
Created attachment 144544 [details] [review]
proposed fix

Currently path to polkit-gnome-authentication-agent-1 in
polkit-gnome-authentication-agent-1.desktop is hardcoded to /usr/libexec what
is not always true.
Comment 1 Vincent Untz 2009-10-02 17:39:09 UTC
Actually, LIBEXECDIR is not good enough either: the agent is put in /usr/lib/polkit-gnome in openSUSE, for example.

So either a configure option, or changing polkit-gnome to provide a pkg-config file that we can use for this.
Comment 2 Vincent Untz 2009-10-02 17:41:40 UTC
See bug 582320 for a similar issue (with g-s-d this time).
Comment 3 Brian Cameron 2009-10-07 18:53:53 UTC
Changing polkit-gnome to provide a pkg-config file seems the right way to fix this.  A GDM configuration option is more hacky, and users are likely to not realize they need to set it.  However, it could be an acceptable short-term workaround if there is difficulty in changing polkit-gnome.

Is there a bug filed against polkit-gnome asking to add such a pkg-config file?
Comment 4 Brian Cameron 2009-10-31 02:32:57 UTC
Having said that, the patch in comment #1 is more sane than what is currently being done.  It also does some of the needed work for a better solution, such as moving the .in file to a .in.in file.  Perhaps this patch should be accepted, and we can fix the remaining issue later?
Comment 5 Ray Strode [halfline] 2009-12-21 20:31:41 UTC
Comment on attachment 144544 [details] [review]
proposed fix

Thanks, I've committed this until we get a better fix in.
Comment 6 Laurent Bigonville 2013-11-11 16:57:06 UTC
This has been fixed for quite some times now, closing

commit dba5ee4c517b9156f70d389bfe31b64d3b7965cc
Author: Ray Strode <rstrode@redhat.com>
Date:   Thu Jul 12 15:56:34 2012 -0400

    data: add desktop file for polkit gnome authentication agent
    
    We now start it in the greeter session, but polkit doesn't
    ship an agent desktop file, so ship our own.