After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596959 - DirectFB backend compilation broken with changes from 2.18.0 to 2.18.1
DirectFB backend compilation broken with changes from 2.18.0 to 2.18.1
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: [obsolete] Backend: directfb
2.18.x
Other Linux
: Normal blocker
: ---
Assigned To: gtk-bugs
Michael Emmel
Depends on:
Blocks:
 
 
Reported: 2009-10-01 07:39 UTC by Sebastian Dröge (slomo)
Modified: 2009-10-02 05:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
directfb-backend-compilation.diff (1.04 KB, patch)
2009-10-01 07:41 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2009-10-01 07:39:54 UTC 
Hi,
the changes that were done from 2.18.0 to 2.18.1 broke the DirectFB backend compilation because _gdk_windowing_window_at_pointer() now takes get_toplevel as parameter instead of global variable.

Possible patch for this follows
Comment 1 Sebastian Dröge (slomo) 2009-10-01 07:40:25 UTC 
/tmp/buildd/gtk+2.0-2.18.1/gdk/directfb/gdkwindow-directfb.c:2077: error: conflicting types for '_gdk_windowing_window_at_pointer'
/tmp/buildd/gtk+2.0-2.18.1/gdk/gdkinternals.h:460: error: previous declaration of '_gdk_windowing_window_at_pointer' was here
/tmp/buildd/gtk+2.0-2.18.1/gdk/directfb/gdkwindow-directfb.c: In function '_gdk_windowing_window_at_pointer':
/tmp/buildd/gtk+2.0-2.18.1/gdk/directfb/gdkwindow-directfb.c:2102: error: 'get_toplevel' undeclared (first use in this function)
/tmp/buildd/gtk+2.0-2.18.1/gdk/directfb/gdkwindow-directfb.c:2102: error: (Each undeclared identifier is reported only once
/tmp/buildd/gtk+2.0-2.18.1/gdk/directfb/gdkwindow-directfb.c:2102: error: for each function it appears in.)
make[5]: *** [gdkwindow-directfb.lo] Error 1
Comment 2 Sebastian Dröge (slomo) 2009-10-01 07:41:42 UTC 
Created attachment 144472 [details] [review]
directfb-backend-compilation.diff
Comment 3 Matthias Clasen 2009-10-02 03:57:16 UTC 
Thanks, please commit
Comment 4 Sebastian Dröge (slomo) 2009-10-02 05:40:48 UTC 
ommit 59177b19322729e50ac6748274f250c04ad08fa0
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Oct 2 07:39:34 2009 +0200

    Bug 596959 - DirectFB backend compilation broken with changes from 2.18.0 to
    
    Fix compilation of the DirectFB backend after internal API changes of GDK.