After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596811 - Import MxTable as StTable
Import MxTable as StTable
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-09-30 04:12 UTC by Owen Taylor
Modified: 2009-10-01 19:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Import MxTable as StTable (77.47 KB, patch)
2009-09-30 04:12 UTC, Owen Taylor 		committed Details | Review
Handle adding children to StTable from Javascript (5.07 KB, patch)
2009-09-30 04:12 UTC, Owen Taylor 		committed Details | Review
Port StTable to StThemeNode (17.10 KB, patch)
2009-09-30 04:13 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2009-09-30 04:12:54 UTC 
Here are patches to import the MxTable code and get it working with our
CSS style code and Javascript.
Comment 1 Owen Taylor 2009-09-30 04:12:56 UTC 
Created attachment 144350 [details] [review]
Import MxTable as StTable

Import table code from Mx library
Comment 2 Owen Taylor 2009-09-30 04:12:59 UTC 
Created attachment 144351 [details] [review]
Handle adding children to StTable from Javascript

Remove the StTable specific methods to add actors:

 st_table_add_actor()
 st_table_add_actor_with_properties()

Since they shadow the generic ClutterContainer add_actor() method,
and patch in our add() convenience function as we do for
StBoxLayout.
Comment 3 Owen Taylor 2009-09-30 04:13:02 UTC 
Created attachment 144352 [details] [review]
Port StTable to StThemeNode

Convert the StTable code from StStylable to StThemeNode. The
:row-spacing and :col-spacing GObject properties are converted
into spacing-rows and spacing-columns style properties.

A new interactive test is added for StTable.
Comment 4 Colin Walters 2009-09-30 21:55:56 UTC 
Review of attachment 144350 [details] [review]:

Assuming there re no substantive changes aside from the rename.
Comment 5 Colin Walters 2009-09-30 21:56:54 UTC 
Review of attachment 144351 [details] [review]:

Kind of unfortunate shadowing; introspection should really have a warning for this at least (ideally disallow it).
Comment 6 Colin Walters 2009-09-30 22:07:00 UTC 
Review of attachment 144352 [details] [review]:

Looks good, though I was confused at first how _allocate worked by just removing the padding until I came on the call to get the content box, then call one of the _allocate functions.  As said on IRC might be nicer if StWidget had separate _content allocation functions.
Comment 7 Owen Taylor 2009-10-01 19:35:21 UTC 
Attachment 144350 [details] pushed as 289b19a - Import MxTable as StTable
Attachment 144351 [details] pushed as af3ec56 - Handle adding children to StTable from Javascript
Attachment 144352 [details] pushed as 5a42179 - Port StTable to StThemeNode