GNOME Bugzilla – Bug 596601
Increase size of volume icon in fullscreen mode
Last modified: 2010-03-09 03:29:35 UTC
in fullscreen mode in the volume icon shown in the bar at the bottom it seems to use a very small size of the volume icon. It's size should be increased to increase clarity and there seems to be a lot of space to do this too. in karmic with it's humanity icon theme, currently the icon is especially small. maybe the size which is used in the gnome panel at the top for volume icon could be used to maintain uniformity. this is NOT a bug with the icon theme. totem seems to use a very small version.
Could you provide a screenshot please? For me, the icon is taking up the full height of the control bar in fullscreen mode, and couldn't be enlarged without making the bar taller.
Is it possible to get a screenshot of the bar in fullscreen mode? I just tried several times, even with a timer set, and as soon as the screenshot fires, the bar disappears. > in karmic with it's humanity icon theme, currently the icon is especially > small. I'm also using Karmic's Humanity icons, and I think I see what you're saying, but... > this is NOT a bug with the icon theme. totem seems to use a very small version. how are you sure of this? I just tried some other icon themes and the volume icon seems to be as big as possible (as Philip said) in those themes. I think that Humanity's volume icon is on the small side. Not much that Totem developers can do about that.
it seems you are right . humanity icons seem to have the problem only.
(In reply to comment #3) > it seems you are right . humanity icons seem to have the problem only. In that case, you might want to check Humanity's Launchpad bug tracker[1]. It might be worth filing a bug there, because I'm not really sure why their icons seem smaller than other themes. I'm going to mark this bug as Invalid, but if you find something that makes "Invalid" seem wrong, feel free to reopen it. [1] https://bugs.launchpad.net/humanity
Created attachment 150345 [details] button becoming smaller with humanity (In reply to comment #4) > (In reply to comment #3) > > it seems you are right . humanity icons seem to have the problem only. > > In that case, you might want to check Humanity's Launchpad bug tracker[1]. It > might be worth filing a bug there, because I'm not really sure why their icons > seem smaller than other themes. > Hi , I'm a member of the humanity-icon-theme team, I dont see how this is a bug in the icon-theme. If you notice totem's behavior , it uses the 22px icon when humanity theme is used and when you switch the icon theme to gnome it uses either the 22px or 24px icon. With humanity , the volume button becomes smaller , and what totem does is , it scales the volume icon down. that is the problem here. It maybe due to the extra padding that the humanity icon has or maybe since totem isnt able to handle the svg icon. IMO , it would be a totem bug , it should be able to just use the icon as-is and not scale/change the button size. Hope this helps. :)
(In reply to comment #5) > It maybe due to the extra padding that the humanity icon has or maybe since > totem isnt able to handle the svg icon. > IMO , it would be a totem bug , it should be able to just use the icon as-is > and not scale/change the button size. Makes sense. > Hope this helps. :) Hopefully it will, thanks! I'm going to reopen the issue and let Totem developers handle it from here.
(In reply to comment #5) > Hi , > I'm a member of the humanity-icon-theme team, I dont see how this is a bug in > the icon-theme. > > If you notice totem's behavior , it uses the 22px icon when humanity theme is > used and when you switch the icon theme to gnome it uses either the 22px or > 24px icon. > With humanity , the volume button becomes smaller , and what totem does is , it > scales the volume icon down. that is the problem here. The size of the volume button is determined by the icon, not the other way round. The button itself is a GtkVolumeButton (with the icons under the control of the code in GtkScaleButton), and out of our control. > It maybe due to the extra padding that the humanity icon has or maybe since > totem isnt able to handle the svg icon. > IMO , it would be a totem bug , it should be able to just use the icon as-is > and not scale/change the button size. The following icons are used by the button: * audio-volume-muted * audio-volume-high * audio-volume-low * audio-volume-medium I haven't looked at them, but if you say they have extra padding, that may be causing them to appear smaller in the button. There should be no problems with handling SVG, since it's done the same way across GTK+.
(In reply to comment #7) > > The size of the volume button is determined by the icon, not the other way > round. The button itself is a GtkVolumeButton (with the icons under the control > of the code in GtkScaleButton), and out of our control. > > The following icons are used by the button: > * audio-volume-muted > * audio-volume-high > * audio-volume-low > * audio-volume-medium > > I haven't looked at them, but if you say they have extra padding, that may be > causing them to appear smaller in the button. There should be no problems with > handling SVG, since it's done the same way across GTK+. Yes , the 22px icons are all basically done to fit in a 16px frame , so they have additional padding of 3px on all sides. [we had to do such a "hack" to try and keep the panel icons uniform in all the applets] I have also noticed the same behavior in rhythmbox. So, I guess its a bug in gtk+ and how the GtkVolumeButton works. Probably , its not an issue with totem. @Praveen: could you open a bug in gtk+ and ping me on irc regarding the bug number? Thanks.
(In reply to comment #8) > @Praveen: could you open a bug in gtk+ and ping me on irc regarding the bug > number? Thanks. …or we could just reassign this bug to GTK+, though I think it's a Humanity problem rather than a GTK+ one.
gtk_scale_button_new() takes an icon size. In Totem, that's GTK_ICON_SIZE_SMALL_TOOLBAR. Fix your theme to have bigger icons for the small toolbar size is all I can advise.
(In reply to comment #10) > gtk_scale_button_new() takes an icon size. In Totem, that's > GTK_ICON_SIZE_SMALL_TOOLBAR. > > Fix your theme to have bigger icons for the small toolbar size is all I can > advise. I think you misunderstood , Humanity *does* have the icon in the required size , 22px . [and also in 16px,24px] But still, gtk scales down the 22px icon . probably to fit into a 16px space? Why does it not just use the 16px icon instead ? Why should the icon-theme's design be restricted because gtk scales the icon even when icons for the standard sizes are provided?? If ,in future, an icon-theme wants to display volume levels as concentric circles starting with a dot or volume level as different sizes of the speaker , then it will have same problems. Why isnt it as simple as... ->app specifies required icon size , ->if icon theme has specified icon size show the icon as-is. ->if not, gtk can just scale icon to fit into the required size. Why should gtk further poke into what is within the icon?
Created attachment 153703 [details] svg confuses gtk (In reply to comment #10) > gtk_scale_button_new() takes an icon size. In Totem, that's > GTK_ICON_SIZE_SMALL_TOOLBAR. > > Fix your theme to have bigger icons for the small toolbar size is all I can > advise. I tried your solution of adding bigger icons , But it _does not_ fix the problem! . The problem is not the size of the icon inside , but rather the _filetype_. Humanity-icon-theme uses fully svg icons. That's what confuses gtk! gtk scales the icon if it is named as an .svg . If i add a symlink to an .svg file named as *.png* it fixes the problem! But , why does gtk scale the svg? Attaching screenshot of the problem and the hack. 1> bigger icon as svg causes scaling and smaller button. 2> same icon is displayed properly if i add a symlink named as .png 3> Notice that blurriness doesnt arise even with the old smaller icon if it is present as a png symlnk.
on ubuntu lucid i no longer get this issue. dont know the reason. so can be closed from my side.
(In reply to comment #13) > on ubuntu lucid i no longer get this issue. dont know the reason. > so can be closed from my side. The reason why the bug is not present in lucid , Is because I'v added symlinks to an _svg_ file but named as .png /Humanity/status/22/audio-volume-high.png and so on. The bug is still present in gtk. If you remove all the png symlinks you'll notice the bug again ;)
so, according to vish's above comment, this bug should be kept open and fixed properly in gtk. so that workarounds like above are not needed.
I don't believe there is any bug in GTK+. I do believe that maybe the Ubuntu themes are a little confused about some details of scaling and size specification in icon themes. In any case, there is no clear description of the problem here, but only unclear claims ('gtk is scaling the 22 icon to 16') and broken workarounds (link svg to png). Please reopen this if there is a clear description of the problem.
(In reply to comment #16) > In any case, there is no clear description of the > problem here, but only unclear claims ('gtk is scaling the 22 icon to 16') and > broken workarounds (link svg to png). The icon was present in 16,22,24px as a svg but that was getting scaled. But the problem disappears when the same icon is present as a .png or atleast as a symlink named as .png The same problem can be observed with any theme. It is reproducible when any theme has svg icons alone. > I don't believe there is any bug in GTK+. I do believe that maybe the Ubuntu > themes are a little confused about some details of scaling and size > specification in icon themes. Could you be more specific what the problem in the theme is , so that it can be fixed in the theme?