After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596337 - Black background on altTab popup
Black background on altTab popup
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-09-25 16:39 UTC by Owen Taylor
Modified: 2009-09-26 21:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[AppSwitcher] Make the background translucent again (4.04 KB, patch)
2009-09-26 16:13 UTC, Dan Winship
committed Details | Review

Description Owen Taylor 2009-09-25 16:39:56 UTC
67bfbc9 Use AppIcon and switch applications rather than windows

Contains, along with other changes:

-POPUP_BG_COLOR.from_pixel(0x00000080);
+POPUP_BG_COLOR.from_pixel(0x000000ff);

Not sure if this was intentional in the patch, but it wasn't meant to be implied in the design ... the soid black rectangle without any border looks a bit weird. Transparent black of some nature is probably still what we want.
Comment 1 Dan Winship 2009-09-26 16:12:47 UTC
Right. So we used to have a white current-app indicator against the translucent/medium gray background, but now our indicator is just the AppIcon border, and AppIcon specifies a border color of light gray, which is not very visible against the dark gray background. So I darkened the background. The other possibility of course would be to lighten the AppIcon border.

We are already doing this:

        // FIXME?
        appIcon.actor.border = 2;

(appIcon defaults to a border with of 1, but that was also too-unnoticeable in the app switcher context). But it looks like we can't just do "appIcon.actor.border_color = WHITE;" though, because AppIcon adjusts its border color each time you select or unselect it. So we'd either have to change the default AppIcon border color (probably bad because the white is a little bit too bold in the overview), or add a border-color "property" to AppIcon.

Or we could go back to using a separate actor for the indicator instead of trying to use the appIcon's border; that would probably be tricky wrt z-ordering with the pop-up menu though...
Comment 2 Dan Winship 2009-09-26 16:13:07 UTC
Created attachment 144078 [details] [review]
[AppSwitcher] Make the background translucent again

The default AppIcon gray border color isn't very visible against a
dark gray background, but a white border looks too bold in the Well. So
allow the caller to override the AppIcon border color, so that the Well
can use gray-on-black and the AppSwitcher can use white-on-gray. (And
then revert the AppSwitcher back to the translucent gray background.)
Comment 3 Owen Taylor 2009-09-26 16:39:51 UTC
Comment on attachment 144078 [details] [review]
[AppSwitcher] Make the background translucent again

Patch looks good. So need to merge the nbtk-introduction branch, this should just be:

+ #altTab .appIcon {
+    border-color: white;
+ }
Comment 4 Dan Winship 2009-09-26 21:23:57 UTC
Attachment 144078 [details] pushed as 72dd458 - [AppSwitcher] Make the background translucent again