GNOME Bugzilla – Bug 596210
Remove MetaAltTabHandler
Last modified: 2009-10-02 19:49:22 UTC
This is not quite ready to commit yet (blocks on bug 590563) but it's ready to review at least. This removes MetaAltTabHandler, since the shell will no longer be using it, thus bringing us down to only two Alt-Tab mechanisms (built-in and meta_keybindings_set_custom_handler). It *doesn't* revert the other tab popup cleanups that were part of bug 580917, although we could do that too if we want to move back closer to upstream metacity. OTOH, we could just remove Alt-Tab support from mutter completely since neither moblin nor gnome-shell will be using the default alt-tab popup...
Created attachment 143925 [details] [review] Remove MetaAltTabHandler gnome-shell is no longer using MetaAltTabHandler, so there's no need to keep that abstraction around. This reverts commit 1d5117a6 (and a comment from 7b0ba87b), with a bit of rebasing and whitespace cleanup.
(In reply to comment #0) No objections to removing MetaAltTabHandler from me. > OTOH, we could just remove Alt-Tab > support from mutter completely since neither moblin nor gnome-shell > will be using the default alt-tab popup... I guess that depends whether we want to Mutter to be usable as a standalone WM, though admittedly, the Alt+Tab support we inherited from Metacity is not too well suited to Mutter. Perhaps something really simple could be built into the default plugin instead.
The current/soon-to-be-ex gnome-shell Alt-Tab implementation (or better yet, the pre-e79b15c6 version) could be ported to C easily enough (it's basically just a Clutter reimplementation of the stock metacity Alt-Tab, using a "lightbox" effect to highlight the selected window rather than metacity's dark black border. It uses tweener, but you could ditch that part). Of course, it depends on MetaAltTabHandler. :-). But you could make it use meta_keybindings_set_custom_handler instead though, you'd just need to copy over the logic for deciding which windows to show and in what order.
Attachment 143925 [details] pushed as d04b15e - Remove MetaAltTabHandler