After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596083 - Deprecate notebook label packing functionality
Deprecate notebook label packing functionality
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkNotebook
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Christian Dywan
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-09-23 14:12 UTC by Christian Dywan
Modified: 2009-11-30 18:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Deprecate label packing (2.89 KB, patch)
2009-09-23 14:20 UTC, Christian Dywan 		committed Details | Review
Mention exact child property names (958 bytes, patch)
2009-11-27 16:34 UTC, Christian Dywan 		committed Details | Review

Description Christian Dywan 2009-09-23 14:12:46 UTC 
The subject was raised and discussed on the mailing list and it was found that packing tab labels with GtkPackType like children of a GtkBox is not something normal applications need and it would make the code  a lot easier if the support could be removed in the future (GTK+ 2.90).
Comment 1 Christian Dywan 2009-09-23 14:20:52 UTC 
Created attachment 143799 [details] [review]
Deprecate label packing
Comment 2 Christian Dywan 2009-10-21 16:25:45 UTC 
Committed to master.
Comment 3 Christian Persch 2009-11-13 17:27:07 UTC 
 * Deprecated: 2.20: Modify the expand and fill child properties instead.

IMHO this should mention the exact child property names, which are "tab-expand" and "tab-fill", not "expand" or "fill".
Comment 4 Christian Dywan 2009-11-27 16:34:47 UTC 
Created attachment 148605 [details] [review]
Mention exact child property names
Comment 5 Matthias Clasen 2009-11-29 23:12:49 UTC 
Looks good, but i have seen gtk-doc run into trouble with quotes in deprecation notes lately. Please make sure it does not break the doc build with current gtk-doc.
Comment 6 Christian Dywan 2009-11-30 11:59:45 UTC 
I made a full build with gtk-doc and it generated a proper HTML page.

Pushed to master.
Comment 7 Javier Jardón (IRC: jjardon) 2009-11-30 18:22:16 UTC 
Comment on attachment 148605 [details] [review]
Mention exact child property names

commit cb49a28f8cc72be570600014e4f8fbb271520f6e
Comment 8 Javier Jardón (IRC: jjardon) 2009-11-30 18:26:54 UTC 
Comment on attachment 143799 [details] [review]
Deprecate label packing

commit 272e0b5b763a5deefe8138fb053fe72ef1ac0d4c