After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 596041 - Accessibe names not displayed for some non-GtkStock toolbar buttons
Accessibe names not displayed for some non-GtkStock toolbar buttons
Status: RESOLVED DUPLICATE of bug 597596
Product: gtk+
Classification: Platform
Component: Class: UIManager / Actions
2.18.x
Other All
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2009-09-23 08:06 UTC by Tim Miao
Modified: 2009-11-27 20:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screen shot (47.50 KB, image/png)
2009-09-24 07:31 UTC, Tim Miao
  Details
Test case (1.38 KB, patch)
2009-09-25 23:24 UTC, Christian Neumair
none Details | Review

Description Tim Miao 2009-09-23 08:06:14 UTC
Steps to reproduce:
1. Start an at-tool, say orca or gok.
2. Open current user home directory in nautilus file manager.
3. Press <Tab> to move focus onto toolbar, then <Arrow> to "Home", "Computer" button.
4. Click Toolbars button in gok main window to grab the toolbar buttons in gok.

Bug observations:
After step3, orca only reads "Button" instead of "Home button" or "This computer button", but the other buttons in toolbar have their accessible name, which can be read by orca.
After step4, gok can not grab the "Home button" and "Computer button".

Expected result:
These buttons should have an accessible name for at-tool accessing.
Comment 1 Christian Neumair 2009-09-23 11:30:51 UTC
Thanks for your bug report. Has this happened in previous Nautilus releases, i.e. 2.26 and before?

Considering how the items are constructed [1,2] it seems very odd that only the "Home" and "Computer" buttons are affected while other buttons like "Up" that are constructed exactly the same way are not affected.

The onliest difference I can see is that "Home" and "Computer" are located within two separators. Isn't the "Search" button affected too?


Maybe you could try to remove the separators 

	<separator/>

from

<toolbar name="Toolbar">
...
</toolbar>

in

$prefix/share/nautilus/ui/nautilus-navigation-window-ui.xml

and try out whether the issue still happens?

[1] http://git.gnome.org/cgit/nautilus/tree/src/nautilus-window-menus.c#n848
[2] http://git.gnome.org/cgit/nautilus/tree/src/nautilus-navigation-window-ui.xml#n63
Comment 2 Tim Miao 2009-09-24 07:31:17 UTC
Created attachment 143872 [details]
screen shot
Comment 3 Tim Miao 2009-09-24 07:31:40 UTC
Please poke nautilus file manager in accerciser and go to accerciser "Interface Viewer" tab, you will find there is no accessible name for only these two buttons, while other buttons have their own accessible names. It looks not because of the separators.
Comment 4 Christian Neumair 2009-09-25 23:22:01 UTC
(In reply to comment #3)
> Please poke nautilus file manager in accerciser (...)

Thanks, I didn't know that tool. It looks like GTK+ has problems when non-GtkStockItem images are used as toolbar buttons. In that case, no accessible name seems to be set for the respective image.

I am confirming and renaming this report, reassigning it to GTK+ and will attach a test case.
Comment 5 Christian Neumair 2009-09-25 23:24:13 UTC
Created attachment 144046 [details] [review]
Test case

In this simple test case, two buttons are displayed in a toolbar: "Back" with the icon GTK_STOCK_GO_BACK, and "Home" with the icon "user-home". The latter is not a GtkStock name, and the button does not have any a11y name.
Comment 6 Matthias Clasen 2009-11-27 20:16:11 UTC

*** This bug has been marked as a duplicate of bug 597596 ***