After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595514 - [lookingGlass] Fix shell_hook_paint_red_border
[lookingGlass] Fix shell_hook_paint_red_border
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-09-17 20:57 UTC by Colin Walters
Modified: 2009-09-21 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[lookingGlass] Fix shell_hook_paint_red_border (1.61 KB, patch)
2009-09-17 20:57 UTC, Colin Walters
accepted-commit_now Details | Review

Description Colin Walters 2009-09-17 20:57:13 UTC
In overriding _paint we're already offset to our allocation
coordinates, don't re-add them.
Comment 1 Colin Walters 2009-09-17 20:57:15 UTC
Created attachment 143407 [details] [review]
[lookingGlass] Fix shell_hook_paint_red_border
Comment 2 Owen Taylor 2009-09-18 14:40:13 UTC
Review of attachment 143407 [details] [review]:

Looks basically fine.

::: src/shell-drawing.c
@@ +195,3 @@
+                  geom.width, geom.height);
+  cogl_rectangle (geom.width - width, geom.height,
+                  0, geom.height - width);

It's very odd to me to draw a rectangle with negative width and height like this. It should work if everything is implemented correctly, but it's confusing.

@@ +197,3 @@
+                  0, geom.height - width);
+  cogl_rectangle (width, geom.height - width,
+                  0, width);

Or like this