GNOME Bugzilla – Bug 595326
Bump libtool to 2.2 and remove dolt
Last modified: 2009-09-23 15:05:15 UTC
Created attachment 143258 [details] [review] Bump libtool to 2.2 - disable dolt Hi This patch bumps libtool to 2.2 - as it is the newest version available and older version will not be fixed, I think this is a wise step. To quote from the libtool site: "... This is the first stable release from the Libtool 2.2 branch. Libtool 2.0 was never released, as by the time 1.9f was released from the stable branch, the head of the development branch had already become much more stable than the supposed stable branch!! Compared to the old stable Libtool 1.5.x branch, the new stable 2.2 branch has been almost entirely rewritten, and has too many improvements and brand new features to enumerate here. Please see the NEWS file in the distribution for a comprehensive list of user visible changes. ... Also ported the macros to the newest version. While at it, I want to remove dolt support. Basically my decision is based on the fact that dolt isn't actively developed and there is no progress in git since 7 months. I don't like the idea of having a ticking time bomb in the build system - as you never know when something could break or is broken and no fix would be available.
While I'm all in favor of dropping non-standard build tools -- especially unsupported ones -- I believe dolt was added to improve linking performance at build time. I'd like to see some build time measurements before we do this.
Created attachment 143292 [details] [review] Fixes dolt with libtool 2.2 After some investigation, I've found out what causes libtool 2.2 to fail with dolt and AM_SILENT_RULES. dolt doesn't support the options of libtool... See http://lists.freedesktop.org/archives/dolt/2008-July/000001.html . I've ported the patch for our own dolt.m4 (as I don't think that this will be integrated upstream), should be applied to evo/eds. Like this I'm not really fine with leaving dolt there, but the build breakage I've seen is fixed - it's okay. Should I add a new patch without the dolt removal or would you just take it out while merging?
I'd still like to see build time measurements before and after...
Hi, for the bugs 595393 , 595327 here some measurements. Details are explained here and specific in bug 595327 : http://pastebin.ca/1569547 dolt is something like a cache for libtool - thus it can bring performance/time improvements in case that libtool is heavily used. However, in eds it are around 5 seconds on my system. The measurements were taken without ccache, after every run it was distcleaned and autom4te.cache was cleaned.
First patch committed to master: http://git.gnome.org/cgit/evolution/commit/?id=ce05a504b7cfc725f17aa71b1b5303a816ddd465 Second patch is obsolete since the first patch removes dolt.m4.