After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595293 - Convert remaining uses of "let me = this;" to Lang.bind
Convert remaining uses of "let me = this;" to Lang.bind
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2009-09-15 17:11 UTC by Dan Winship
Modified: 2009-09-15 17:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Convert remaining uses of "let me = this;" to Lang.bind (14.77 KB, patch)
2009-09-15 17:11 UTC, Dan Winship
accepted-commit_now Details | Review
Convert remaining uses of "let me = this;" to Lang.bind (14.77 KB, patch)
2009-09-15 17:34 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2009-09-15 17:11:22 UTC
I noticed windowManager.js was still using "let me = this;" and fixed
it, then fixed one or two other places, and removed a handful of stale
"let me"s that were no longer used anyway
Comment 1 Dan Winship 2009-09-15 17:11:24 UTC
Created attachment 143236 [details] [review]
Convert remaining uses of "let me = this;" to Lang.bind
Comment 2 Colin Walters 2009-09-15 17:23:09 UTC
Comment on attachment 143236 [details] [review]
Convert remaining uses of "let me = this;" to Lang.bind

Sure, I assume you did the "git grep me\."
Comment 3 Dan Winship 2009-09-15 17:34:21 UTC
The following fix has been pushed:
ceefc5e Convert remaining uses of "let me = this;" to Lang.bind
Comment 4 Dan Winship 2009-09-15 17:34:23 UTC
Created attachment 143240 [details] [review]
Convert remaining uses of "let me = this;" to Lang.bind