After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594585 - Should build with -DGSEAL_ENABLE
Should build with -DGSEAL_ENABLE
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: general
SVN TRUNK
Other Linux
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on: 69872
Blocks: 585391
 
 
Reported: 2009-09-09 03:14 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-05-16 09:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use accessor functions instead direct access (17.12 KB, patch)
2009-09-09 03:19 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Use accessor functions instead direct access.part2 (1.10 KB, patch)
2009-09-22 18:19 UTC, Javier Jardón (IRC: jjardon) 		accepted-commit_now Details | Review

Description Javier Jardón (IRC: jjardon) 2009-09-09 03:14:38 UTC 
To be ready for GNOME 3 should be able to build with -DGSEAL_ENABLE

See http://live.gnome.org/GnomeGoals/UseGseal for more details
Comment 1 Javier Jardón (IRC: jjardon) 2009-09-09 03:19:51 UTC 
Created attachment 142760 [details] [review]
Use accessor functions instead direct access

Still missing:
GTK_WIDGET_UNSET_FLAGS (applet->popup, GTK_TOPLEVEL);
Comment 2 Richard Hughes 2009-09-09 07:39:42 UTC 
Fine with me, please commit.
Comment 3 Javier Jardón (IRC: jjardon) 2009-09-09 11:57:32 UTC 
Thank you Richard, 

Could someone commit this? (I don't have commit permissions)
Comment 4 Luis Medinas 2009-09-10 02:18:30 UTC 
Comment on attachment 142760 [details] [review]
Use accessor functions instead direct access

Committed per Javier request. 

Thanks
Comment 5 Javier Jardón (IRC: jjardon) 2009-09-10 03:43:57 UTC 
Ropening as there is still one missing function: 
GTK_WIDGET_UNSET_FLAGS (applet->popup, GTK_TOPLEVEL);
Comment 6 Javier Jardón (IRC: jjardon) 2009-09-22 18:19:00 UTC 
Created attachment 143721 [details] [review]
Use accessor functions instead direct access.part2

Removed GTK_WIDGET_UNSET_FLAGS (applet->popup, GTK_TOPLEVEL) because a popup *is* a toplevel

With this patch gnome-power-manager compiles with -DGSEAL_ENABLED without any problem
Comment 7 Richard Hughes 2009-09-23 07:04:17 UTC 
Comment on attachment 143721 [details] [review]
Use accessor functions instead direct access.part2

Please commit. Thanks!
Comment 8 Richard Hughes 2009-10-06 13:35:07 UTC 
Committed, thanks.
Comment 9 Richard Hughes 2010-05-16 09:00:29 UTC 
This seems to break the popup. You can't click on the slider without the popup closing...