After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594505 - Menu option "Disconnect" is present on DAAP share even for disconnected shares
Menu option "Disconnect" is present on DAAP share even for disconnected shares
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: DAAP
0.12.x
Other Linux
: Normal minor
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-08 14:45 UTC by Michal Nowak
Modified: 2018-05-24 14:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Context menu with item "Disconnect" (18.15 KB, image/png)
2009-09-08 14:45 UTC, Michal Nowak
  Details
gstvalue: Add datetime gvalue (9.74 KB, patch)
2010-04-29 18:40 UTC, Thiago Sousa Santos
rejected Details | Review

Description Michal Nowak 2009-09-08 14:45:37 UTC
Created attachment 142702 [details]
Context menu with item "Disconnect"

Context menu for disconnected share has item "Disconnect" which is a bit weird.
The MSGBOX shows that I was not connected to the box at all. 

rhythmbox-0.12.4-3.fc12.x86_64

Have a look at the attachment.
Comment 1 Thiago Sousa Santos 2010-04-29 18:40:48 UTC
Created attachment 159934 [details] [review]
gstvalue: Add datetime gvalue

Simple patch that implements the datetime fields all separate into
the GValue.

From the code:
/*
 * Brief explanation of datetime representation in a GValue:
 *
 * We store each field separately, they are: year, month, day of month,
 * hour, minute, second, nanosecs, timezone (in minutes), dst (bit)
 *
 * Those are stored as:
 * at the first uint64:
 *   unused:24, year:16, month:4, day:5, hour:5, minutes:4, secs:6
 * at the second uint64:
 *   unused:22, nanosecs:30, timezone:11, dst:1
 *
 * TODO:
 * - how to do validation?
 */

How does it sound?

(Yes, tests are needed, this is just to give an idea)
Comment 2 Jonathan Matthew 2010-04-29 20:26:18 UTC
Comment on attachment 159934 [details] [review]
gstvalue: Add datetime gvalue

Wrong bug number?
Comment 3 Thiago Sousa Santos 2010-04-29 21:19:40 UTC
Yep, sorry for the noise :(
Comment 4 GNOME Infrastructure Team 2018-05-24 14:41:34 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/806.