GNOME Bugzilla – Bug 594500
timeout of password dialog
Last modified: 2015-03-11 23:17:41 UTC
When I try to connect to a password-protected dav share (that was exported via gnome-user-share), I get a password dialog. That is fine. But if I leave the password dialog untouched for a few minutes, I get an error dialog, that says Unable to mount location DBus error org.freedesktop.DBus.Error.NoReply: Message did not receive a reply (timeout by message bus) That is not very friendly. If you show a password dialog, you should be prepared for it to stay open for a while. And if you really can't just keep waiting, a better way to handle the timeout would be to just remove the password dialog (and MAYBE show a nice message that explains the timeout)
Another big problem with the error dialog is that the grab of the password dialog prevents me from clicking its ok button.
Created attachment 298832 [details] [review] common: Increase mount timeout to 30 minutes Although it is probably unnecessary, wait up to 30 minutes for a mount to complete. This allows plenty of time to wait for a password dialog. It also makes it more consistent with many of the other operations which use a timeout of 30 minutes.
The error message shown when the timeout occurs is: "Timeout was reached" which I think is OK.
Review of attachment 298832 [details] [review]: Agree that it is good idea to unify those timeouts across gvfs, but why not use this macro also for g_dbus_proxy_set_default_timeout calls in gmountsource...
Created attachment 299053 [details] [review] common: Increase mount timeout to 30 minutes Although it is probably unnecessary, wait up to 30 minutes for a mount to complete. This allows plenty of time to wait for a password dialog. It also makes it more consistent with many of the other operations which use a timeout of 30 minutes.
Review of attachment 299053 [details] [review]: Looks good, thanks!
Comment on attachment 299053 [details] [review] common: Increase mount timeout to 30 minutes Pushed to master as c0bd3138a60b2a389ac99540ac3bfecb700ef0ff. Thanks for the review.