After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594283 - rtpbin: make free_session() remove dangling stream references
rtpbin: make free_session() remove dangling stream references
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal critical
: 0.10.17
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-06 00:12 UTC by Håvard Graff (hgr)
Modified: 2009-09-08 11:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.42 KB, patch)
2009-09-06 00:12 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2009-09-06 00:12:59 UTC 
Created attachment 142575 [details] [review]
patch

When receiving a sync-packet, all sessions with the same cname will be compared
and synced together. In this process, there could still be references to a
session that has been shut down in the meanwhile. 

This patch makes sure that these references are removed when shutting down a
session, so that the syncing can be done safely.

This patch, together with bug #594248, has made shutting down a session
mid-call safe for us! 

The author of this patch is Stig Sandnes: stig.sandnes@tandberg.com
Comment 1 Wim Taymans 2009-09-08 11:19:56 UTC 
commit 8f3299c5474530d0a0b353160816d5b841b5d7cb
Author: Stig Sandnes <stig.sandnes@tandberg.com>
Date:   Tue Sep 8 13:18:29 2009 +0200

    rtpbin: make free_session() remove stream references
    
    When receiving a sync-packet, all sessions with the same cname will be compared
    and synced together. In this process, there could still be references to a
    session that has been shut down in the meanwhile.
    
    This patch makes sure that these references are removed when shutting down a
    session, so that the syncing can be done safely.
    
    Fixes #594283