After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 594280 - directdrawsink: avoid rendering to invalid area
directdrawsink: avoid rendering to invalid area
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-05 23:53 UTC by Håvard Graff (hgr)
Modified: 2011-02-08 17:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.64 KB, patch)
2009-09-05 23:53 UTC, Håvard Graff (hgr) 		rejected Details | Review

Description Håvard Graff (hgr) 2009-09-05 23:53:14 UTC 
Created attachment 142574 [details] [review]
patch

Check to see if we have an area to draw to.
Comment 1 Sebastian Dröge (slomo) 2009-09-08 14:03:08 UTC 
That patch doesn't look correct. If both differences are negative there shouldn't be any rendering but your patch still renders then. Other than that it looks ok
Comment 2 Tobias Mueller 2010-04-19 10:46:00 UTC 
Havard, could you address the issues raised by Sebastian? Would be a pity if the patch couldn't make it in. Thanks in advance.
Comment 3 Tobias Mueller 2010-06-04 11:52:29 UTC 
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!
Comment 4 Tim-Philipp Müller 2010-06-04 12:03:28 UTC 
Tobias: please don't close bugs with patches as INCOMPLETE, especially not if parts of them are known to be good (see comment #1). Thanks!
Comment 5 Mark Nauwelaerts 2011-02-08 17:07:29 UTC 
Looks like being 0 is most relevant here (rather than negative).

Anyway, pushed with minor adjustments (e.g. check for valid rectangle before doing aspect ratio calculation stuff):

commit edb15598ed566f37d90129492a86341badee0672
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Mon Feb 7 22:47:34 2011 +0100

    directdrawsink: avoid rendering to invalid area
    
    Based on patch by Havard Graff <havard.graff@tandberg.com>
    
    Fixes #594280.