After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593594 - Orca says "blank" when Firefox returns a bogus value for getTextAtOffset
Orca says "blank" when Firefox returns a bogus value for getTextAtOffset
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.27.x
Other All
: Normal normal
: 2.28.1
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2009-08-31 00:53 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-09-24 23:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
fix (3.97 KB, patch)
2009-08-31 01:00 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2009-08-31 00:53:47 UTC
The Gecko script works hard to identify and work around bogus return values for getTextAtOffset. If I do say so myself, we catch most of the bogusity. There is one instance of persistent bogusity which I'd not gotten around to fixing, however. An example can be seen in the line_nav_bug_547573.py regression test (Assertion 82. Line Up).
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-08-31 01:00:09 UTC
Created attachment 142092 [details] [review]
fix

This patch fixes the aforementioned problem. Pylinted and regression tested. I've committed this to master (and only master) so it can get some more testing. Pending user feedback, this should be considered for inclusion in 2.28.1.
Comment 2 Joanmarie Diggs (IRC: joanie) 2009-09-24 23:19:54 UTC
Now that code freeze is over, I've committed this fix to the GNOME-2-28 branch for inclusion in 2.28.1