GNOME Bugzilla – Bug 593520
The Gecko script's getBottomOfFile needs to be more efficient
Last modified: 2009-09-24 23:32:39 UTC
Right now the Gecko script's getBottomOfFile method looks for the last object and then uses findNextCaretInOrder to move from the last object to the last character. This allows us to deal with the various and sundry goofiness we encounter in web content. Unfortunately, however, if the last embedded object character is many characters away from the last character in the document frame, pressing Control End while Orca is controlling the caret will result in a very long wait. :-(
Created attachment 142009 [details] [review] fix This patch adds an initial check to getBottomOfFile: If the last character in the document frame is not an embedded object character, we return the document frame and the offset of that last character. This solves the problem of the test case, is pylinted, and fully regression tested. Because we've branched for 2.28, I've committed this patch to master (and only master) so that it will get tested by our bleeding-edge users. Assuming it doesn't have any unforeseen side effects, we should consider including this for 2.28.1.
In order to track bugs/fixes which we want to keep in mind for 2.28.1 without having to keep all of those bugs open and in limbo until then, I'm going to start adding "2.28.1?" to the whiteboard.
Now that code freeze is over, I've committed this fix to the gnome-2-28 branch for inclusion in 2.28.1