After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 593045 - wrong description for gvfs-copy, -move, -save
wrong description for gvfs-copy, -move, -save
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Christian Kellner
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2009-08-25 17:46 UTC by Jonh Wendell
Modified: 2010-02-18 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixed description for gvfs-mkdir (821 bytes, patch)
2009-08-25 17:47 UTC, Jonh Wendell
committed Details | Review

Description Jonh Wendell 2009-08-25 17:46:53 UTC
trivial patch is coming
Comment 1 Jonh Wendell 2009-08-25 17:47:30 UTC
Created attachment 141667 [details] [review]
Fixed description for gvfs-mkdir
Comment 2 Christian Persch 2009-08-25 18:26:41 UTC
+  context = g_option_context_new (_("- create directories"));
Actually N_() should be used here; plus a call to g_option_context_set_translation_domain().
Comment 3 Jonh Wendell 2009-08-25 18:45:27 UTC
Isn't N_() designed for declarations, instead of function calls?
Comment 4 Claude Paroz 2009-08-29 19:32:46 UTC
In fact, this problem can also be found in other gvfs programs. E.g. gvfs-copy, gvfs-move and gvfs-save all have the description:

context = g_option_context_new (_("- output files at <location>"));

which I find a little weird. And don't forget we are now in string freeze.
Comment 5 Christian Kellner 2009-10-01 16:06:17 UTC
Attachment 141667 [details] pushed as 5ce0a03 on master
Comment 6 Claude Paroz 2009-10-02 06:44:35 UTC
Christian, you didn't address the issue I mentioned on comment 4. Should we reopen the bug or you do you prefer I enter a new bug?
Comment 7 Christian Kellner 2009-10-02 11:07:47 UTC
Claude, Alex and myself don't see any problems with marking that string for translation directly with "_( )". Could you please give me an explanation why that is wrong?
Comment 8 Claude Paroz 2009-10-02 12:23:10 UTC
Sorry not to be clear enough. It has nothing to do with translation, but about the description content.
In programs/gvfs-copy.c:
context = g_option_context_new (_("- output files at <location>"));
In programs/gvfs-move.c:
context = g_option_context_new (_("- output files at <location>"));
In programs/gvfs-save.c:
context = g_option_context_new (_("- output files at <location>"));

Is it on purpose that the 3 descriptions are identical?
Comment 9 Christian Kellner 2009-10-02 21:20:44 UTC
Sorry, that indeed was a misunderstanding. You are clearly right. Reopening the bug and now changing the description. Thanks for catching that. I will take care of that on monday.
Comment 10 Christian Kellner 2010-02-18 16:28:13 UTC
Fixed on git master (e177788..0344cf3). Not exactly "on monday" ;-)