GNOME Bugzilla – Bug 593045
wrong description for gvfs-copy, -move, -save
Last modified: 2010-02-18 16:28:13 UTC
trivial patch is coming
Created attachment 141667 [details] [review] Fixed description for gvfs-mkdir
+ context = g_option_context_new (_("- create directories")); Actually N_() should be used here; plus a call to g_option_context_set_translation_domain().
Isn't N_() designed for declarations, instead of function calls?
In fact, this problem can also be found in other gvfs programs. E.g. gvfs-copy, gvfs-move and gvfs-save all have the description: context = g_option_context_new (_("- output files at <location>")); which I find a little weird. And don't forget we are now in string freeze.
Attachment 141667 [details] pushed as 5ce0a03 on master
Christian, you didn't address the issue I mentioned on comment 4. Should we reopen the bug or you do you prefer I enter a new bug?
Claude, Alex and myself don't see any problems with marking that string for translation directly with "_( )". Could you please give me an explanation why that is wrong?
Sorry not to be clear enough. It has nothing to do with translation, but about the description content. In programs/gvfs-copy.c: context = g_option_context_new (_("- output files at <location>")); In programs/gvfs-move.c: context = g_option_context_new (_("- output files at <location>")); In programs/gvfs-save.c: context = g_option_context_new (_("- output files at <location>")); Is it on purpose that the 3 descriptions are identical?
Sorry, that indeed was a misunderstanding. You are clearly right. Reopening the bug and now changing the description. Thanks for catching that. I will take care of that on monday.
Fixed on git master (e177788..0344cf3). Not exactly "on monday" ;-)