Created attachment 141567 [details] [review]
revision 1

Will please review. Thanks!

(In reply to comment #0)
> (This is a spin-off bug from bug 590680.)
> 
> Arrowing around in the Style combo because causes bits of text to be repeated
> and the word 'selected' to be tacked on.

Where is the Style combo?

Formatting toolbar. Says Default, Heading 1, etc.

By the way, to test that patch you need to first change the selection (at which point we say nothing), then move focus to something else (like Font), and then try changing the selection in Style again.

http://qa.openoffice.org/issues/show_bug.cgi?id=104290

Comment on attachment 141567 [details] [review]
revision 1

Thanks!  This is a definite improvement worthy of 2.28. :-)  One thing I noticed, however, is that when I arrow left/right through the text in the style name, nothing is presented.

Created attachment 141579 [details] [review]
revision 2

The fact that we were speaking nothing when Left/Right was pressed was indeed a result of revision 1. Sorry! This revision puts things back to the way they were when Left and Right Arrow are pressed, namely: We preface all but the initial keypress with "unselected". This is due to http://qa.openoffice.org/issues/show_bug.cgi?id=104470 (just filed) which we are tracking via bug 592927.

I tried to figure out a hack to work around this "unselected, unselected, unselected" issue, but I couldn't come up with anything that I could count on being safe across the board. :-(

Thoughts?

As per team meeting, I've committed revision 2 to both master and the gnome-2-28 branch. Closing as FIXED.