GNOME Bugzilla – Bug 592795
Show /whois info when selecting information on a irc user
Last modified: 2011-05-16 13:16:58 UTC
if i am in a irc chat room and i right click on a user and click information i get really no useful information at all. pidgin shows me info like which all chat rooms he has joined etc. so as much information is actually shared should be displayed
Let's focus on the list of chat rooms for now. This requiers enhancement in different modules: - telepathy-spec: the spec should be extended to give this information from the CM to the client - telepathy-idle: once we have a spec telepathy-idle should implement it - Empathy: once implemnted in Idle, Empathy should use the spec and display this information. This bug can be used to track the Empathy part but is blocked on the 2 other points. Feel free to open bugs on https://bugs.freedesktop.org/ for those.
Well well. What have we here? Could it be an Empathy branch that exposes some of the information that very very recent Idle versions expose on ContactInfo? http://cgit.collabora.co.uk/git/user/wjt/empathy.git/log/?h=more-contact-info
Created attachment 187583 [details] Here's what I look like. This screenshot doesn't show an away message. It shows the clicky channel links that you can click on to join that channel. I realised after attaching this screenshot that a better description for idle times might be “Last seen:”, maybe. There's some extra spacing before the channel list and I'm not really sure why.
Created attachment 187609 [details] [review] diff Attaching diff for review.
Review of attachment 187609 [details] [review]: Looks pretty good! ::: libempathy-gtk/empathy-contact-widget.c @@ +351,3 @@ + * and should bin this. + */ + * with their IM client. "Away message" maybe? @@ +601,3 @@ +{ + GtkWidget *w; + return TRUE; label_markup is leaked.
Created attachment 187698 [details] [review] Add empathy_duration_to_string() This is based on the body of empathy_time_to_string_relative(); it takes a duration in seconds, rather than a timestamp.
Created attachment 187699 [details] [review] ContactWidget: show IRC channel list. Very recent versions of Idle expose the list of channels provided in WHOIS replies. The data is provided as a bunch of x-irc-channel fields with a single value, namely the name of the channel. Here we expose that data to the user as a comma-separated list of links; clicking a link ensures that channel.
Created attachment 187700 [details] [review] ContactWidget: generalize linkifying values Many of the new fields exposed by Idle need more processing than just bunging the first string into a label. Let's start by generalizing linkifying the first string. I speculatively allow the format functions to fail.
Created attachment 187701 [details] [review] ContactWidget: support Idle's x-idle-time field.
Created attachment 187702 [details] [review] ContactWidget: support IRC server and host info
Created attachment 187703 [details] [review] ContactWidget: expose IRC presence information This is basically just a temporary hack until Idle implements SimplePresence.
Review of attachment 187698 [details] [review]: ++
Review of attachment 187699 [details] [review]: ++
Review of attachment 187700 [details] [review]: ++
Review of attachment 187701 [details] [review]: ++
Review of attachment 187702 [details] [review]: ++
Review of attachment 187703 [details] [review]: ++
Mergèd!