After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 592776 - keyboard mnemonics don't work
keyboard mnemonics don't work
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnomine
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2009-08-23 05:59 UTC by Matthias Clasen
Modified: 2009-08-24 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (652 bytes, patch)
2009-08-23 05:59 UTC, Matthias Clasen 		accepted-commit_now Details | Review

Description Matthias Clasen 2009-08-23 05:59:34 UTC 
Created attachment 141472 [details] [review]
patch

this is because the key_press handler eats all key events.
Comment 1 Christian Persch 2009-08-23 18:32:28 UTC 
Comment on attachment 141472 [details] [review]
patch

Thanks!
Comment 2 Jason Clinton 2009-08-24 17:06:20 UTC 
commit 370caa5f5bd25f005e810405b5b122c2fb1e0328
Author: Matthias Clasen <mclasen@redhat.com>
Date:   Mon Aug 24 12:06:00 2009 -0500

    gnomine: Fix keyboard mnemonics don't work #592776

diff --git a/gnomine/gnomine.c b/gnomine/gnomine.c
index 639028d..cb0798f 100644
--- a/gnomine/gnomine.c
+++ b/gnomine/gnomine.c
@@ -647,7 +647,7 @@ window_state_callback (GtkWidget * widget, GdkEventWindowState * event)
 }
 
 
-static void
+static gboolean
 pause_key_callback(GtkWidget *widget, GdkEventKey *event,
 gpointer data )
 {
@@ -658,8 +658,11 @@ gpointer data )
       resume_game_cb(NULL, NULL); // Resume the game
     else
       pause_callback(NULL, NULL, NULL); // Pause the game
+
+    return TRUE;
   }
-                       
+
+  return FALSE;
 }